Place Woopay “Direct Checkout” Behind a Feature Flag #8088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo
requested review from
a team and
bborman22
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
bborman22
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
I was able to test this feature flag out locally after getting some local domain issues resolved (couldn't use just localhost as my WooPay domain, set up a hosts file entry for woopay.test instead).
A couple things I tested:
- ✅ Test with
_wcpay_feature_woopay_direct_checkoutflag enabled (yes redirect) - ✅ Test with
_wcpay_feature_woopay_first_party_authflag disabled (no redirect) - ✅ Test with WooPay overall disabled (no redirect)
- ✅ Test with an adapated extension enabled (Gift Cards) (no redirect)
This hits on all the main test scenarios from what I can tell and they all worked as expected. The code changes are also following other feature patterns and looked good!
ricardo
added
the
status: blocked
|
Marking as blocked so that we don't merge until #7890 is ready. |
@bborman22, this PR is independent enough from #7890 to be merged independently, so I don't have a preference; either way, works. Although, if we decide to merge this branch (i.e. |
Good call. In general, I think I'd prefer this PR gets merged into |
This is a great call-out. This also applies when switching between commits in the repo. With this said, I agree that it's better to merge this branch into the |
lovo-h
removed
the
status: blocked
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2445-gh-Automattic/woopay
Changes proposed in this Pull Request
_wcpay_feature_woopay_direct_checkoutoption feature flag.Testing instructions
_wcpay_feature_woopay_direct_checkoutset to1.0and ensure the user is always redirected to the merchant checkout._wcpay_feature_woopay_direct_checkoutto1and_wcpay_feature_woopay_first_party_authto0and ensure the user is always redirected to the merchant checkout.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge