Bring back the rest-user-exists-controller file #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an error that happens during the plugin upgrade process. We'll need to keep this file until a more robust solution is found.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
shendy-a8c
requested changes
May 15, 2023
changelog/fix-plugin-upgrade
Outdated
| Significance: patch | ||
| Type: fix | ||
|
|
||
| Missing file during plugin upgrade |
There was a problem hiding this comment.
I suggest to not add any changelog for this PR as the problem this PR is trying to fix did not exist in previous version.
There was a problem hiding this comment.
Sorry, I meant not to remove the whole changelog file because then GH check for changelog will fail.
You can:
- Run
npm run changelog. - Choose
patch. - Leave empty when prompted with "Changelog entry. May be left empty if this change is particularly insignificant".
- Leave a comment why you put an empty changelog.
I know that npm run changelog isn't too clear.
I talked about it several times, eg p1683308423223529/1683298938.613009-slack-CGGCLBN58
There was a problem hiding this comment.
Oh I misunderstood. Added an empty changelog with a comment
|
I updated PR description with better reproduce steps and error. |
Looks like the |
shendy-a8c
approved these changes
May 15, 2023
There was a problem hiding this comment.
Besides changelog concern, this PR should be good to merge. Approving.
shendy-a8c
added a commit
that referenced
this pull request
May 16, 2023
Co-authored-by: Shendy <[email protected]>
This was referenced Jul 10, 2023
|
@malithsen @shendy-a8c Is this file still needed after half a year? As I understand, this is code that is not being used, but it is left for upgrade purposes. |
@vladolaru This is correct. If we remove it, there's the risk of users upgrading from 5.8.x to a later version running into the error, but at this point % of versions below, that seems to be less than 1.5% 469f8fdffca011514a0024294f6dca43-logstash. Even for those users, it will not prevent the upgrade. So, I don't have any strong objections to removing this file. For some additional context, this issue is being discussed in paJDYF-aZa-p2 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error that happens during the plugin upgrade process.
class-wc-rest-user-exists-controller.phpand its references were removed in #6174During the plugin upgrade process,
init_rest_apiof the current WCPay version is invoked. This results in printing an error during the upgrade. This PR adds the file back to silence the error until we find a more robust solution.Changes proposed in this Pull Request
class-wc-rest-user-exists-controller.phpfile removed in Remove WooPay subscriptions user check endpoint #6174Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge