Add empty file to avoid fatals #7936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
timur27
force-pushed
the
revert/file-needed-for-plugin-update
branch
2 times, most recently
from
560d9b2 to
506c7bd
Compare
timur27
force-pushed
the
revert/file-needed-for-plugin-update
branch
from
506c7bd to
55322aa
Compare
timur27
requested review from
a team and
brettshumaker
and removed request for
a team
brettshumaker
requested changes
Dec 20, 2023
Co-authored-by: Brett Shumaker <[email protected]>
brettshumaker
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on p1703066593001019-slack-CGGCLBN58
Changes proposed in this Pull Request
Due to some unexpected way of performing operations during the plugin update, some errors might pop up. paJDYF-aZa-p2 is all about it. When
class-wc-rest-upe-flag-toggle-controller.phpwas removed in #7821 together with its invocation inclass-wc-payments.php, we faced another issue of the same nature (p1702991864368429/1702991804.354289-slack-C011ENB20Q1).This error is not fatal (doesn't prevent from plugin update) nor is it shown to the merchants because they don't have debug log mode enabled on their sites. But since we previously approached same problem by reverting (#6303 as example), this PR also reverts the file so that the error doesn't appear.
The file can be empty. p1703073471085769/1703066593.001019-slack-CGGCLBN58
Testing instructions
6.9.2by defaultPayments -> Settings -> Advanced settingsand confirm Debug mode is enabled6.9.27.0.0version with the fix (in other words zip based on this PR) and use it to update the plugin versionnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge