Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the rest-user-exists-controller file #6303

Merged
merged 6 commits into from
May 15, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-plugin-upgrade
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Missing file during plugin upgrade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to not add any changelog for this PR as the problem this PR is trying to fix did not exist in previous version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 1dd9f40

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant not to remove the whole changelog file because then GH check for changelog will fail.

You can:

  • Run npm run changelog.
  • Choose patch.
  • Leave empty when prompted with "Changelog entry. May be left empty if this change is particularly insignificant".
  • Leave a comment why you put an empty changelog.

I know that npm run changelog isn't too clear.

I talked about it several times, eg p1683308423223529/1683298938.613009-slack-CGGCLBN58

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I misunderstood. Added an empty changelog with a comment

78 changes: 78 additions & 0 deletions includes/admin/class-wc-rest-user-exists-controller.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
<?php
/**
* Class WC_REST_User_Exists_Controller
*
* @package WooCommerce\Payments\Admin
*/

defined( 'ABSPATH' ) || exit;

/**
* REST controller to check if a user exists.
*/
class WC_REST_User_Exists_Controller extends WP_REST_Controller {

/**
* Endpoint namespace.
*
* @var string
*/
protected $namespace = 'wc/v3';

/**
* Endpoint path.
*
* @var string
*/
protected $rest_base = 'users/exists';

/**
* Configure REST API routes.
*/
public function register_routes() {
register_rest_route(
$this->namespace,
'/' . $this->rest_base,
[
'methods' => WP_REST_Server::CREATABLE,
'callback' => [ $this, 'user_exists' ],
'permission_callback' => '__return_true',
'args' => [
'email' => [
'required' => true,
'description' => __( 'Email address.', 'woocommerce-payments' ),
'type' => 'string',
'format' => 'email',
],
],
]
);
}

/**
* Retrieve if a user exists by email address.
*
* @param WP_REST_Request $request Full details about the request.
*
* @return WP_REST_Response
*/
public function user_exists( WP_REST_Request $request ): WP_REST_Response {
$email = $request->get_param( 'email' );
$email_exists = ! empty( email_exists( $email ) );
$message = null;

if ( $email_exists ) {
// Use this function to show the core error message.
$error = wc_create_new_customer( $email );
$message = $error->get_error_message();
}

return new WP_REST_Response(
[
'user-exists' => $email_exists,
'message' => $message,
]
);
}
}