Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Implements the epilogue story design notes #566

Merged
merged 5 commits into from
Dec 5, 2022

Conversation

emilylaguna
Copy link
Contributor

📘 Project: #374 🛫 Depends on: #564

This addresses the following items:

  • Updates the replay button to:
    • Use a different font
    • Adjust paddings
    • Use the design replay icon
  • Updates the spacing
  • Highlights Pocket Casts in the text

This also:

  • Changes how the interactive stories work to no longer need to duplicate the entire story view for it to have interactive elements

Screenshots

Design vs Implementation Comparison

Devices

iPhone SE - 14.1 iPhone 13 iPhone 14 Pro Max

To test

  1. Launch the app
  2. Tap on the Profile Tab > End of Year Card
  3. Tap to the end
  4. ✅ Verify the view looks good and matches the designs
  5. ✅ Verify the Replay button works
  6. ✅ Verify the close button works
  7. ✅ Repeat the steps on various screen sizes

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@emilylaguna emilylaguna added the [Project] End of Year 2023 End of Year project label Dec 3, 2022
@emilylaguna emilylaguna added this to the 7.28 ❄️ milestone Dec 3, 2022
@emilylaguna emilylaguna requested a review from a team as a code owner December 3, 2022 06:49
Base automatically changed from project-eoy-376/story-7-design-review to release/7.28 December 5, 2022 16:48
@emilylaguna emilylaguna merged commit 1b380c6 into release/7.28 Dec 5, 2022
@emilylaguna emilylaguna deleted the project-eoy-376/epilogue-design-review branch December 5, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants