-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End of Year: Epilogue Grand Finale Idea #567
End of Year: Epilogue Grand Finale Idea #567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilylaguna I left a comment about adding a library to have a specific effect.
I think the confetti is fine but I wouldn't consider these changes to have a high impact.
@@ -163,6 +163,15 @@ | |||
"version": "7.25.1" | |||
} | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really, really avoid adding a new library just for this effect (and at this point).
I already plan to remove the EoY files from the final app build once we remove the feature in January. Of course, we can also remove that but I wonder if it really worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I did this for a quick proof of concept idea.
I asked the designers for input on this, and if it's something they want to do I can update the package reference to my own version of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this!
This implements a bit more pizazz on the epilogue view based on the design review notes:
Video
RPReplay_Final1670052102.MP4
To test
Checklist
CHANGELOG.md
if necessary.