Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Epilogue Grand Finale Idea #567

Merged
merged 11 commits into from
Dec 5, 2022

Conversation

emilylaguna
Copy link
Contributor

📘 Project: #376 🛫 Depends on: #566

This implements a bit more pizazz on the epilogue view based on the design review notes:

  • Changes background to black
  • Adds confetti
  • Adds a shiny effect to the heart to add a pop of interactive color
  • Adds haptics when the confetti appears

Video

RPReplay_Final1670052102.MP4

To test

  1. You should test this on a real device
  2. Go to Profile > End of Year Card
  3. Tap through to the second to last view
  4. Let the last story play out, and hold your device in your hand
  5. ✅ Verify the epilogue appears with some extra flare
  6. ✅ Verify the haptics play and feel cool
  7. ✅ Tilt your device around for extra effects

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@emilylaguna emilylaguna added Needs design This issues needs design input [Project] End of Year 2023 End of Year project labels Dec 3, 2022
@emilylaguna emilylaguna added this to the 7.28 ❄️ milestone Dec 3, 2022
@emilylaguna emilylaguna requested a review from a team as a code owner December 3, 2022 07:31
Copy link
Member

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilylaguna I left a comment about adding a library to have a specific effect.

I think the confetti is fine but I wouldn't consider these changes to have a high impact.

@@ -163,6 +163,15 @@
"version": "7.25.1"
}
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really, really avoid adding a new library just for this effect (and at this point).

I already plan to remove the EoY files from the final app build once we remove the feature in January. Of course, we can also remove that but I wonder if it really worth it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I did this for a quick proof of concept idea.

I asked the designers for input on this, and if it's something they want to do I can update the package reference to my own version of it.

Base automatically changed from project-eoy-376/epilogue-design-review to release/7.28 December 5, 2022 16:49
Copy link
Member

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this!

@emilylaguna emilylaguna merged commit fdc298c into release/7.28 Dec 5, 2022
@emilylaguna emilylaguna deleted the project-eoy-376/epilogue-flare-idea branch December 5, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs design This issues needs design input [Project] End of Year 2023 End of Year project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants