Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Year: Fix sharing logo not appearing #568

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

emilylaguna
Copy link
Contributor

📘 Project: #376 🛫 Depends on: #566

This fixes an issue where the PC logo would not appear when being shared. It fixes this by creating a shared container view that the story and logo are rendered in.

Screenshots

Before After

To test

  1. Launch the app
  2. Tap the Profile Tab > End of Year Card
  3. Tap through each story and share the image
  4. ✅ Verify the PC logo appears
  5. ✅ Verify the view renders, and looks good
  6. Repeat the steps for various screen sizes

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@emilylaguna emilylaguna added the [Project] End of Year 2023 End of Year project label Dec 3, 2022
@emilylaguna emilylaguna added this to the 7.28 ❄️ milestone Dec 3, 2022
@emilylaguna emilylaguna requested a review from a team as a code owner December 3, 2022 07:39
@emilylaguna emilylaguna changed the title Project eoy 376/fix pc logo when sharing End of Year: Fix sharing logo not appearing Dec 3, 2022
@leandroalonso
Copy link
Member

@emilylaguna one final thought: it feels weird to me that the first and the last story expand to fill the whole screen. I know this is how it is on the designs but I feel it would be better if the "share button" was somehow just hidden, keeping the size of the stories consistent across all of them.

@emilylaguna
Copy link
Contributor Author

one final thought: it feels weird to me that the first and the last story expand to fill the whole screen

The designs initially had the gap available there, but when I implemented it having the gap IMO looked super out of place. Here's a quick demo of what that looked like:

Simulator.Screen.Recording.-.4.-.iPhone.13.-.16.-.4.-.2022-12-05.at.10.53.03.mp4

So I ended up just hiding the button entirely.

@leandroalonso
Copy link
Member

@emilylaguna hm yeah. Seeing it now the result is weird. Thanks for the context!

Base automatically changed from project-eoy-376/epilogue-design-review to release/7.28 December 5, 2022 16:49
@emilylaguna emilylaguna merged commit 65031b5 into release/7.28 Dec 5, 2022
@emilylaguna emilylaguna deleted the project-eoy-376/fix-pc-logo-when-sharing branch December 5, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Project] End of Year 2023 End of Year project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants