Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable deactivate and delete for Akismet #2593

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

gamebits
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds akismet to the list of "required" plugins for the Newspack platform. Coupled with the PR in the private Manager repository, it makes it difficult to deactivate or delete this plugin from the Plugins dashboard page.

How to test the changes in this Pull Request:

Follow instructions in the private manager plugin repository.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@gamebits gamebits requested a review from a team as a code owner August 10, 2023 21:11
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 14, 2023
@leogermani
Copy link
Contributor

@gamebits Where's the PR in the private repo you mention?

@leogermani leogermani added [Status] Needs changes or feedback The issue or pull request needs action from the original creator and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 23, 2023
@gamebits
Copy link
Contributor Author

Where's the PR in the private repo you mention?

@leogermani Ah! I copied this PR's text from #1712. The ability to block plugins was added in https://github.com/Automattic/newspack-manager/pull/40.

@gamebits gamebits requested a review from dkoo September 11, 2023 14:24
@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Sep 11, 2023
@laurelfulford laurelfulford merged commit 136752a into master Sep 15, 2023
1 check passed
@laurelfulford laurelfulford deleted the feat/akismet-always-on branch September 15, 2023 17:14
matticbot pushed a commit that referenced this pull request Sep 15, 2023
# [2.7.0-alpha.1](v2.6.1...v2.7.0-alpha.1) (2023-09-15)

### Bug Fixes

* partial text domain update for the newspack plugin ([#2646](#2646)) ([7d92092](7d92092))

### Features

* add ads.txt manager to plugin manager ([#2639](#2639)) ([06eccaa](06eccaa))
* **amp-deprecation:** remove AMP from supported list ([#2647](#2647)) ([ef98476](ef98476))
* disable deactivate and delete for Akismet ([#2593](#2593)) ([136752a](136752a))
* replace recommended cookie plugin ([#2223](#2223)) ([4a309be](4a309be))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Sep 25, 2023
# [2.7.0](v2.6.4...v2.7.0) (2023-09-25)

### Bug Fixes

* partial text domain update for the newspack plugin ([#2646](#2646)) ([7d92092](7d92092))

### Features

* add ads.txt manager to plugin manager ([#2639](#2639)) ([06eccaa](06eccaa))
* **amp-deprecation:** remove AMP from supported list ([#2647](#2647)) ([ef98476](ef98476))
* disable deactivate and delete for Akismet ([#2593](#2593)) ([136752a](136752a))
* replace recommended cookie plugin ([#2223](#2223)) ([4a309be](4a309be))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge [Status] Needs changes or feedback The issue or pull request needs action from the original creator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants