Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ads.txt manager to plugin manager #2639

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Adds ads.txt manager to plugin manager #2639

merged 2 commits into from
Sep 15, 2023

Conversation

gamebits
Copy link
Contributor

Adds 10up's Ads.txt Manager plugin to Newspack's list of approved/recommended/default plugins.

All Submissions:

Changes proposed in this Pull Request:

Adds 10up's Ads.txt Manager plugin to Newspack's list of approved/recommended/default plugins. See 1204015893379290-as-1204159745402806.

How to test the changes in this Pull Request:

  1. Navigate to /wp-admin/plugins.php
  2. Note that Ads.txt Manager is among the default plugins listed with a hyphen prefix.
  3. Install and activate the plugin.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@gamebits
Adds ads.txt manager to plugin manager
0f545c2 
Adds 10up's [Ads.txt Manager](https://wordpress.org/plugins/ads-txt/) plugin to Newspack's list of approved/recommended/default plugins. See 1204015893379290-as-1204159745402806.
@gamebits gamebits requested a review from a team as a code owner September 11, 2023 15:24
dkoo
dkoo requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, functionally! The PHP linter is complaining about spacing and indentation issues—can you fix before merging?

@gamebits
Fixing spacing
98dc398 
Darn linter
@gamebits
Copy link
Contributor Author

@dkoo I've pushed 98dc398 which should fix the spacing issues the linter reported.

@github-actions github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Sep 11, 2023
@laurelfulford laurelfulford merged commit 06eccaa into master Sep 15, 2023
1 check passed
@laurelfulford laurelfulford deleted the feat/ads-txt-manager branch September 15, 2023 17:15
@gamebits gamebits restored the feat/ads-txt-manager branch September 15, 2023 17:30
@dkoo dkoo deleted the feat/ads-txt-manager branch September 15, 2023 17:54
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 2.7.0-alpha.1 [skip ci]
bd08e4c 
# [2.7.0-alpha.1](v2.6.1...v2.7.0-alpha.1) (2023-09-15)

### Bug Fixes

* partial text domain update for the newspack plugin ([#2646](#2646)) ([7d92092](7d92092))

### Features

* add ads.txt manager to plugin manager ([#2639](#2639)) ([06eccaa](06eccaa))
* **amp-deprecation:** remove AMP from supported list ([#2647](#2647)) ([ef98476](ef98476))
* disable deactivate and delete for Akismet ([#2593](#2593)) ([136752a](136752a))
* replace recommended cookie plugin ([#2223](#2223)) ([4a309be](4a309be))
matticbot pushed a commit that referenced this pull request Sep 25, 2023
@semantic-release-bot
chore(release): 2.7.0 [skip ci]
1b5c78e 
# [2.7.0](v2.6.4...v2.7.0) (2023-09-25)

### Bug Fixes

* partial text domain update for the newspack plugin ([#2646](#2646)) ([7d92092](7d92092))

### Features

* add ads.txt manager to plugin manager ([#2639](#2639)) ([06eccaa](06eccaa))
* **amp-deprecation:** remove AMP from supported list ([#2647](#2647)) ([ef98476](ef98476))
* disable deactivate and delete for Akismet ([#2593](#2593)) ([136752a](136752a))
* replace recommended cookie plugin ([#2223](#2223)) ([4a309be](4a309be))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

gamebits added a commit that referenced this pull request Oct 6, 2023
@gamebits
feat: add Perfmatters to managed plugins
aeceb04 
Adds Perfmatters to our list of managed plugins. Also deletes Perfmatters, SCAIP, and Ads.txt Manager from our list of "supported, but not managed" plugins, since they are in fact managed (SCAIP as of #246 and Ads.txt Manager as of #2639).
@gamebits gamebits mentioned this pull request Oct 6, 2023
Merged
6 tasks
adekbadek pushed a commit that referenced this pull request Oct 9, 2023
@gamebits
feat: add Perfmatters to managed plugins (#2684)
eb657d8 
Adds Perfmatters to our list of managed plugins. Also deletes Perfmatters, SCAIP, and Ads.txt Manager from our list of "supported, but not managed" plugins, since they are in fact managed (SCAIP as of #246 and Ads.txt Manager as of #2639).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gamebits @matticbot @dkoo @laurelfulford