Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable deactivate and delete for required plugins #1712

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jun 15, 2022

All Submissions:

Changes proposed in this Pull Request:

Adds wp-parsely to the list of "required" plugins for the Newspack platform. Coupled with the PR in the private Manager repository, it makes it difficult to deactivate or delete this plugin from the Plugins dashboard page.

Closes #1702.

How to test the changes in this Pull Request:

Follow instructions in the private manager plugin repository.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added [Status] Needs Review The issue or pull request needs to be reviewed Managed Newspack labels Jun 15, 2022
@dkoo dkoo requested a review from a team as a code owner June 15, 2022 21:08
@dkoo dkoo self-assigned this Jun 15, 2022
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jun 20, 2022
@dkoo dkoo merged commit 75afee8 into master Jun 20, 2022
@dkoo dkoo deleted the feat/support-always-on branch June 20, 2022 16:19
matticbot pushed a commit that referenced this pull request Jul 1, 2022
# [1.86.0-alpha.1](v1.85.0...v1.86.0-alpha.1) (2022-07-01)

### Bug Fixes

* **reader-revenue:** disable WC email if module will send email ([#1709](#1709)) ([48e1613](48e1613)), closes [#1699](#1699)

### Features

* ads onboarding ([#1678](#1678)) ([80c0bf4](80c0bf4))
* disable deactivate and delete for required plugins ([#1712](#1712)) ([75afee8](75afee8))
* **experimental:** magic links ([#1668](#1668)) ([02d9f82](02d9f82))
* **reader-revenue:** prevent creating duplicate stripe webhooks ([#1710](#1710)) ([586e693](586e693))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.86.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 11, 2022
# [1.86.0](v1.85.2...v1.86.0) (2022-07-11)

### Bug Fixes

* **reader-revenue:** disable WC email if module will send email ([#1709](#1709)) ([48e1613](48e1613)), closes [#1699](#1699)

### Features

* ads onboarding ([#1678](#1678)) ([80c0bf4](80c0bf4))
* disable deactivate and delete for required plugins ([#1712](#1712)) ([75afee8](75afee8))
* **experimental:** magic links ([#1668](#1668)) ([02d9f82](02d9f82))
* **reader-revenue:** prevent creating duplicate stripe webhooks ([#1710](#1710)) ([586e693](586e693))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.86.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Managed Newspack released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require wp-parsely plugin if a Newspack-hosted site
3 participants