Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reader-revenue): prevent creating duplicate stripe webhooks #1710

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #1666.

How to test the changes in this Pull Request:

  1. On a site with Stripe set up a the Reader Revenue platform, visit the Reader Revenue wizard
  2. If Stripe webhook exists for the site, confirm that another one can't be added ("Create Webhook" button is disabled)
  3. If Stripe webhook does not exist, confirm it can be added

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Jun 13, 2022
@adekbadek adekbadek requested a review from a team as a code owner June 13, 2022 13:30
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! I would recommend we change the messaging to indicate that the webhook has already been created, on top of disabling the button.

@adekbadek
Copy link
Member Author

Added in dc890be

@adekbadek adekbadek requested a review from dkoo June 21, 2022 15:44
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jun 21, 2022
@adekbadek adekbadek merged commit 586e693 into master Jun 22, 2022
matticbot pushed a commit that referenced this pull request Jul 1, 2022
# [1.86.0-alpha.1](v1.85.0...v1.86.0-alpha.1) (2022-07-01)

### Bug Fixes

* **reader-revenue:** disable WC email if module will send email ([#1709](#1709)) ([48e1613](48e1613)), closes [#1699](#1699)

### Features

* ads onboarding ([#1678](#1678)) ([80c0bf4](80c0bf4))
* disable deactivate and delete for required plugins ([#1712](#1712)) ([75afee8](75afee8))
* **experimental:** magic links ([#1668](#1668)) ([02d9f82](02d9f82))
* **reader-revenue:** prevent creating duplicate stripe webhooks ([#1710](#1710)) ([586e693](586e693))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.86.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 11, 2022
# [1.86.0](v1.85.2...v1.86.0) (2022-07-11)

### Bug Fixes

* **reader-revenue:** disable WC email if module will send email ([#1709](#1709)) ([48e1613](48e1613)), closes [#1699](#1699)

### Features

* ads onboarding ([#1678](#1678)) ([80c0bf4](80c0bf4))
* disable deactivate and delete for required plugins ([#1712](#1712)) ([75afee8](75afee8))
* **experimental:** magic links ([#1668](#1668)) ([02d9f82](02d9f82))
* **reader-revenue:** prevent creating duplicate stripe webhooks ([#1710](#1710)) ([586e693](586e693))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.86.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@adekbadek adekbadek deleted the fix/stripe-prevent-dupe-webhook branch July 12, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader Revenue: prevent duplicate Stripe webhook creation
3 participants