Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification tools: remove old Tools interface #21846

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Verification tools: remove old Tools interface #21846

merged 1 commit into from
Nov 22, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Nov 22, 2021

Fixes #21823

Changes proposed in this Pull Request:

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Jetpack > Settings > Traffic, and enable Site Verification tools.
  • Go to the Tools menu.
  • You should not see any settings anymore.

@jeherve jeherve added this to the jetpack/10.4 milestone Nov 22, 2021
@jeherve jeherve added [Feature] Verification tools [Pri] Low [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Nov 22, 2021
@jeherve jeherve self-assigned this Nov 22, 2021
@jeherve
Verification tools: remove old Tools interface
fbc65bc 
Fixes #21823

The tools have lived in the Jetpack dashboard for more than 3 years, since #10039. Let's retire that redirection now.
@jeherve jeherve force-pushed the rm/verification-tools-wp-admin branch from 852a1d2 to fbc65bc Compare November 22, 2021 15:00
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Nov 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

anomiex
anomiex approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as promised

@anomiex anomiex added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Nov 22, 2021
@jeherve jeherve merged commit 02fc0c9 into master Nov 22, 2021
@jeherve jeherve deleted the rm/verification-tools-wp-admin branch November 22, 2021 16:28
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 22, 2021
davidlonjon added a commit that referenced this pull request Nov 23, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-workflow-dependencies-trigger
f8c41bf 
* master: (45 commits)
  Prepare for Boost 1.3.1-beta (#21853)
  Add 'View all purchases' and 'Activate a product' buttons in My Plan card footer. (#21824)
  Move Woop menu item method to parent class so filter can be used in WPCOMSH.  (#21717)
  Dismiss licenses activation notice when license is activated. (#21844)
  assets: Stop `_doing_it_wrong` wrong (#21852)
  Update/jetpack backup version 1.0.1 (#21851)
  assets: Release 1.13.0 (#21847)
  Verification tools: remove old Tools interface (#21846)
  Connection: deactivate the Connection Manager UI (#21828)
  assets: Have `register_script()` take a textdomain (#21831)
  Update/inform first connected plugin (#21672)
  Analyzer: Handle more code tokens (#21652)
  Post List: Release version 0.2.4 (#21820)
  New workflow to push Boost issues to Project Board (#21800)
  Gist Shortcode: refactor unit tests (#21781)
  REST API: Return user ID for comment author if present. (#21834)
  Add License Activation Flow to Jetpack Plugin  (#21764)
  Update wordpress monorepo (#21832)
  docs: Add some tips about handling merge issues (#21825)
  Update error screens and detect backup retry (#21735)
  ...
davidlonjon added a commit that referenced this pull request Nov 23, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-tests
5cf05e9 
* master: (45 commits)
  Prepare for Boost 1.3.1-beta (#21853)
  Add 'View all purchases' and 'Activate a product' buttons in My Plan card footer. (#21824)
  Move Woop menu item method to parent class so filter can be used in WPCOMSH.  (#21717)
  Dismiss licenses activation notice when license is activated. (#21844)
  assets: Stop `_doing_it_wrong` wrong (#21852)
  Update/jetpack backup version 1.0.1 (#21851)
  assets: Release 1.13.0 (#21847)
  Verification tools: remove old Tools interface (#21846)
  Connection: deactivate the Connection Manager UI (#21828)
  assets: Have `register_script()` take a textdomain (#21831)
  Update/inform first connected plugin (#21672)
  Analyzer: Handle more code tokens (#21652)
  Post List: Release version 0.2.4 (#21820)
  New workflow to push Boost issues to Project Board (#21800)
  Gist Shortcode: refactor unit tests (#21781)
  REST API: Return user ID for comment author if present. (#21834)
  Add License Activation Flow to Jetpack Plugin  (#21764)
  Update wordpress monorepo (#21832)
  docs: Add some tips about handling merge issues (#21825)
  Update error screens and detect backup retry (#21735)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Verification tools [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Type] Janitorial
Projects
None yet
Milestone
jetpack/10.4
Development

Successfully merging this pull request may close these issues.

Site Verification link available to Editors
2 participants
@jeherve @anomiex