Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add some tips about handling merge issues #21825

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 19, 2021

Changes proposed in this Pull Request:

This seems like a good place to document tips and workarounds for
handling issues that commonly come up when doing git merge or the
like.

Jetpack product discussion

None direct. Probably this sort of thing has been been passed around by word of mouth.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Check the added docs for correctness, grammar, and spelling.

This seems like a good place to document tips and workarounds for
handling issues that commonly come up when doing `git merge` or the
like.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Docs [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Low labels Nov 19, 2021
@anomiex anomiex self-assigned this Nov 19, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@kraftbj kraftbj merged commit 0c67561 into master Nov 19, 2021
@kraftbj kraftbj deleted the add/document-tips-for-merge-issues branch November 19, 2021 19:05
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Nov 19, 2021
davidlonjon added a commit that referenced this pull request Nov 23, 2021
* master: (45 commits)
  Prepare for Boost 1.3.1-beta (#21853)
  Add 'View all purchases' and 'Activate a product' buttons in My Plan card footer. (#21824)
  Move Woop menu item method to parent class so filter can be used in WPCOMSH.  (#21717)
  Dismiss licenses activation notice when license is activated. (#21844)
  assets: Stop `_doing_it_wrong` wrong (#21852)
  Update/jetpack backup version 1.0.1 (#21851)
  assets: Release 1.13.0 (#21847)
  Verification tools: remove old Tools interface (#21846)
  Connection: deactivate the Connection Manager UI (#21828)
  assets: Have `register_script()` take a textdomain (#21831)
  Update/inform first connected plugin (#21672)
  Analyzer: Handle more code tokens (#21652)
  Post List: Release version 0.2.4 (#21820)
  New workflow to push Boost issues to Project Board (#21800)
  Gist Shortcode: refactor unit tests (#21781)
  REST API: Return user ID for comment author if present. (#21834)
  Add License Activation Flow to Jetpack Plugin  (#21764)
  Update wordpress monorepo (#21832)
  docs: Add some tips about handling merge issues (#21825)
  Update error screens and detect backup retry (#21735)
  ...
davidlonjon added a commit that referenced this pull request Nov 23, 2021
* master: (45 commits)
  Prepare for Boost 1.3.1-beta (#21853)
  Add 'View all purchases' and 'Activate a product' buttons in My Plan card footer. (#21824)
  Move Woop menu item method to parent class so filter can be used in WPCOMSH.  (#21717)
  Dismiss licenses activation notice when license is activated. (#21844)
  assets: Stop `_doing_it_wrong` wrong (#21852)
  Update/jetpack backup version 1.0.1 (#21851)
  assets: Release 1.13.0 (#21847)
  Verification tools: remove old Tools interface (#21846)
  Connection: deactivate the Connection Manager UI (#21828)
  assets: Have `register_script()` take a textdomain (#21831)
  Update/inform first connected plugin (#21672)
  Analyzer: Handle more code tokens (#21652)
  Post List: Release version 0.2.4 (#21820)
  New workflow to push Boost issues to Project Board (#21800)
  Gist Shortcode: refactor unit tests (#21781)
  REST API: Return user ID for comment author if present. (#21834)
  Add License Activation Flow to Jetpack Plugin  (#21764)
  Update wordpress monorepo (#21832)
  docs: Add some tips about handling merge issues (#21825)
  Update error screens and detect backup retry (#21735)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants