Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requested jetpack components version number #20294

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

sgomes
Copy link
Contributor

@sgomes sgomes commented Jul 7, 2021

The repo currently doesn't build because of a version mismatch in jetpack-components.

Fixes bug introduced in #20288.

Changes proposed in this Pull Request:

  • Match requested jetpack-components version to available version.

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Check out the branch
  • Run pnpm i
  • Ensure it works correctly, without complaining about missing dependencies

@sgomes sgomes added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. Build labels Jul 7, 2021
@sgomes sgomes requested review from jeherve and kangzj July 7, 2021 11:53
Copy link

@test-case-reminder test-case-reminder bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Connection

  • In-place connection with free plan
  • In-place connection with paid plan
  • In-place connection with product purchase
  • Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
  • Disconnect/reconnect connection
  • Secondary user connection
  • Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

  • WooCommerce Payments
  • Jetpack Boost
  • Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello sgomes! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D63785-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Package] Connection UI This package no longer exists in the monorepo. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: July 20, 2021.
  • Scheduled code freeze: July 15, 2021.

@github-actions github-actions bot added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 7, 2021
@sgomes sgomes added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 7, 2021
@jeherve jeherve added this to the jetpack/10.0 milestone Jul 7, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 7, 2021
@jeherve jeherve enabled auto-merge (squash) July 7, 2021 12:59
@jeherve jeherve merged commit f8c4578 into master Jul 7, 2021
@jeherve jeherve deleted the fix/update-requested-components-version-number branch July 7, 2021 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Great news! One last step: head over to your WordPress.com diff, D63785-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 7, 2021
@jeherve
Copy link
Member

jeherve commented Jul 7, 2021

r228301-wpcom

@kangzj
Copy link
Contributor

kangzj commented Jul 7, 2021

@sgomes thanks heaps for fixing this 👍 will ask the crew before doing any other major changes in the future.

@sgomes
Copy link
Contributor Author

sgomes commented Jul 8, 2021

No worries, @kangzj , happy to help! FYI, #20297 from @anomiex should help prevent similar situations in the future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build [Package] Connection UI This package no longer exists in the monorepo. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants