Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Make "check-composer-deps" into "check-intra-monorepo-deps" #20297

Merged
merged 2 commits into from
Jul 7, 2021
Merged

tools: Make "check-composer-deps" into "check-intra-monorepo-deps" #20297

merged 2 commits into from
Jul 7, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jul 7, 2021

Changes proposed in this Pull Request:

In other words, have it also check intra-monorepo JS package
dependencies.

And while I'm at it, have it check the monorepo root composer.json too.

Jetpack product discussion

p1625657891311300-slack-CDLH4C1UZ

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Test 1:

  • Check out the first commit of this PR.
  • Run tools/check-intra-monorepo-deps.sh, see it complain about @automattic/jetpack-connection deps that weren't updated in Jetpack 9.9 Changelog #20214.
  • Run tools/check-intra-monorepo-deps.sh -u, see it reproduce the second commit of this PR.

Test 2:

  • Edit the monorepo root composer.json to depend on a wrong version of automattic/jetpack-codesniffer.
  • Run tools/check-intra-monorepo-deps.sh, see it complain about that.
  • Run tools/check-intra-monorepo-deps.sh -u, see it fix it (and not try to create a change entry for the monorepo root).

Test 3:

  • Edit projects/plugins/backup/package.json to change the version of @automattic/jetpack-connection, and projects/plugins/backup/composer.json to change the version of one of the monorepo PHP packages.
  • Run tools/check-intra-monorepo-deps.sh, see it complain about both.
  • Run tools/check-intra-monorepo-deps.sh -u, see it fix both but only create one change entry.

anomiex added 2 commits July 7, 2021 10:21
@anomiex
tools: Make "check-composer-deps" into "check-intra-monorepo-deps"
7e75cfd 
In other words, have it also check intra-monorepo JS package
dependencies.

And while I'm at it, have it check the monorepo root composer.json too.
@anomiex
Update deps
0fad892
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jul 7, 2021
@anomiex anomiex self-assigned this Jul 7, 2021
test-case-reminder[bot]
test-case-reminder bot reviewed Jul 7, 2021
View reviewed changes
Copy link

@test-case-reminder test-case-reminder bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Connection

  • In-place connection with free plan
  • In-place connection with paid plan
  • In-place connection with product purchase
  • Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
  • Disconnect/reconnect connection
  • Secondary user connection
  • Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

  • WooCommerce Payments
  • Jetpack Boost
  • Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D63795-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Package] Connection UI This package no longer exists in the monorepo. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Actions GitHub actions used to automate some of the work around releases and repository management labels Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Backup plugin:

  • Next scheduled release: August 3, 2021.
  • Scheduled code freeze: July 26, 2021.

Jetpack plugin:

  • Next scheduled release: July 20, 2021.
  • Scheduled code freeze: July 15, 2021.

jeherve
jeherve approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 7, 2021
@jeherve jeherve added this to the jetpack/10.0 milestone Jul 7, 2021
@anomiex anomiex merged commit 6e9dd12 into master Jul 7, 2021
@anomiex anomiex deleted the add/check-intra-monorepo-deps branch July 7, 2021 16:22
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Great news! One last step: head over to your WordPress.com diff, D63795-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@anomiex
Copy link
Contributor Author

anomiex commented Jul 7, 2021

r228314-wpcom

@sgomes sgomes mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@test-case-reminder test-case-reminder[bot] test-case-reminder[bot] left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@anomiex anomiex

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Package] Connection UI This package no longer exists in the monorepo. [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anomiex @matticbot @jeherve