Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Components: init version 0.0.2 #20288

Merged
merged 2 commits into from
Jul 7, 2021
Merged

JS Components: init version 0.0.2 #20288

merged 2 commits into from
Jul 7, 2021

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Jul 7, 2021

Changes proposed in this Pull Request:

Init jetpack-components version 0.0.2. Updated using tools/project-version.sh -u 0.2.0-alpha js-packages/components

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Ensure all version strings are updated

@kangzj kangzj self-assigned this Jul 7, 2021
@kangzj kangzj requested review from sdixon194 and a team July 7, 2021 04:35
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 7, 2021
@kangzj kangzj removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 7, 2021
jeherve
jeherve previously approved these changes Jul 7, 2021
View reviewed changes
@jeherve jeherve added this to the jetpack/10.0 milestone Jul 7, 2021
@jeherve
Copy link
Member

jeherve commented Jul 7, 2021

We usually update those versions in the PRs that start modifying the package to avoid having to deal with it with a separate changelog entry, PR, and everything, but I suppose it works in its own PR too :)

@kangzj
Copy link
Contributor Author

kangzj commented Jul 7, 2021

We usually update those versions in the PRs that start modifying the package to avoid having to deal with it with a separate changelog entry, PR, and everything, but I suppose it works in its own PR too :)

Oh sorry I should've asked. Thanks will do next time :-)

@kangzj kangzj force-pushed the add/init-js-components-002 branch from 4c587fe to 145240a Compare July 7, 2021 09:30
@kangzj kangzj enabled auto-merge (squash) July 7, 2021 09:33
@kangzj kangzj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Jul 7, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 7, 2021
@kangzj kangzj merged commit a34181b into master Jul 7, 2021
@kangzj kangzj deleted the add/init-js-components-002 branch July 7, 2021 11:04
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 7, 2021
sgomes added a commit that referenced this pull request Jul 7, 2021
@sgomes
Update requested jetpack components version number
57ae069 
Fixes bug introduced in #20288
@sgomes sgomes mentioned this pull request Jul 7, 2021
Merged
jeherve added a commit that referenced this pull request Jul 7, 2021
@sgomes @jeherve
Update requested jetpack components version number (#20294)
f8c4578 
* Update requested jetpack components version number

Fixes bug introduced in #20288

* Add changelogger entry to other project

* Update version number to start new cycle

Co-authored-by: Jeremy Herve <[email protected]>
@kangzj kangzj mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@sdixon194 sdixon194 Awaiting requested review from sdixon194

Assignees

@kangzj kangzj

Labels
[JS Package] Components RNA
Projects
None yet
Milestone
jetpack/10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kangzj @jeherve