RNA: Add Jetpack footer

[kangzj]

Changes proposed in this Pull Request:

Added two components,

1. A8C SVG Title: 'An Automattic Airline'
2. Jetpack Admin footer, uses the SVG title above and a Jetpack branding
3. Added plugin:@wordpress/eslint-plugin/i18n to check i18n text domain.

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

• Go to projects/js-packages/components and run pnpm run test

• Ensure unit tests pass

• Checkout Search: Add search admin page footer #20252 and follow test instructions

• Ensure components in footer are rendered properly

• Ensure eslint fails if i18n text domain is set to strings other than jetpack

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello kangzj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D63771-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ⚠️ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

[jsnmoon]

Looks like this needs a rebase/master merge; diff currently includes changes from #20288.

[kangzj]

Looks like this needs a rebase/master merge; diff currently includes changes from #20288.

Thank you @jsnmoon and @jeherve for the review 👍 . Rebased and addressed feedback.

[jsnmoon]

Found places for small tweaks here and there. Nonetheless, this looks ready for crew review!

[kangzj]

This looks good to me. I have one question here.

Good point. Committed. And also update #20252 for testing. Thanks 👍

[jeherve]

This looks good to me, although I can't seem to see the footer at all when using the Beta plugin; I only see it on my local installation. I think it may be that the components do not get built when using the Beta plugin?

In any case, that's probably not something to address in this PR. Logged this in #20330.

feedback already addressed.

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D63771-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

[kangzj]

🚢 r228524-wpcom

[sergeymitr]

Hi @kangzj.
Good job on building the component.
We're about to build a similar one for header, and there'll likely be other layout components later on.

So I'm thinking that instead of putting them all into jetpack-components, we should group them all in the new package jetpack-layout.

Do you see any potential undesired consequences of doing that?
I didn't manage to find any consumers of the footer component, are there any?

[kangzj]

So I'm thinking that instead of putting them all into jetpack-components, we should group them all in the new package jetpack-layout.

Do you see any potential undesired consequences of doing that?
I didn't manage to find any consumers of the footer component, are there any?

Hi @sergeymitr sure thing, I think it will be clearer. Tbh we are super happy just to consume them :-)

• The search admin page is using it Search: Add search admin page footer #20252
• I think @jwebbdev is going to use it for the Backup plugin

[kangzj]

Hi @sergeymitr

Would it make sense to use the WordPress abstraction from @wordpress/element instead of React itself here? --@jeherve

Just while you are here, are we going to import @wordpress/element instead of React?