Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Packages: add build tasks to composer.json #20330

Closed
jeherve opened this issue Jul 12, 2021 · 2 comments
Closed

JS Packages: add build tasks to composer.json #20330

jeherve opened this issue Jul 12, 2021 · 2 comments
Labels
[JS Package] Components [JS Package] Connection [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Jul 12, 2021

Steps to reproduce the issue

  1. Start from a site with an active Jetpack Search subscription, using the Jetpack Beta plugin, and with the branch from Search: Add search admin page footer #20252 (add/search-admin-page-footer) active.
  2. Follow the instructions in Search: Add search admin page footer #20252.
  3. You will not see the component used in the footer.

I think that may be because the JS packages do not have build-production and build-development tasks that would allow them to get built.

@anomiex Could that be it, or is the problem something else here?

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [JS Package] Connection [JS Package] Components labels Jul 12, 2021
@anomiex
Copy link
Contributor

anomiex commented Jul 12, 2021

  1. Created a JN site (profitable-quokka) with that branch and a "Jetpack Complete" license issued.
  2. Went to https://profitable-quokka.jurassic.ninja/wp-admin/admin.php?page=jetpack-search&a8ctest
  3. Footer is present. Not sure what else I'm supposed to be looking for.

While I see no build steps listed in composer.json in js-packages/connection and js-packages/components, I also see no sign that there are any build steps for either one in package.json or elsewhere.

Sanity check: Did you rebuild Jetpack itself to pick up the new component?

@jeherve
Copy link
Member Author

jeherve commented Jul 12, 2021

I do see the footer too, now. I must have picked the branch before it was finished rebuilding after its last commit. False alert :)

Thanks for looking.

Sanity check: Did you rebuild Jetpack itself to pick up the new component?

It did work for me locally, so it was okay there.

@jeherve jeherve closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components [JS Package] Connection [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants