Tools: add ardupilot_gazebo to install-ROS-ubuntu script - WIP #21680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmachuca77
suggested changes
Sep 10, 2022
| @@ -209,8 +209,43 @@ heading "${green}Initializaing rosdep${reset}" | |||
| sudo rosdep init || true | |||
| # To find available packages, use: | |||
| rosdep update | |||
|
|
|||
| # Installing ardupilot_gazebo | |||
| git clone https://github.com/SwiftGust/ardupilot_gazebo | |||
There was a problem hiding this comment.
this should point to https://github.com/ardupilot/ardupilot_gazebo
If that repo is missing something when we should make pull requests to that repo to bring it up to date.
There was a problem hiding this comment.
Actually this is incorrect... this should be cloned into the workspace and be part of the ardupilot_ws .....
rmackay9
force-pushed
the
snktshrma-ros-gazebo
branch
from
64a78da
to
61fb93b
Compare
Co-authored-by: Jaime Machuca <[email protected]>
rmackay9
force-pushed
the
snktshrma-ros-gazebo
branch
from
61fb93b
to
9d59d0f
Compare
|
@jmachuca77 happy with this now? |
rmackay9
changed the title
|
Thanks for the follow-up. A number of issues have appeared with this script. I've created an issue and @snktshrma is working on some fixes. .. so for now I've changed this to a WIP. References PRs and issues: |
|
Closing in favour of #22598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for PR #21678 which adds gazebo to the AP-ROS install scripts. This is all @snktshrma's work, I've raise the PR just to get over some merge issues.
The purpose of all of this of course is to make it easy to get AP and ROS running at least in SITL.