Tools: add ardupilot_gazebo to install-ROS-ubuntu script #21678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
requested changes
Sep 9, 2022
There was a problem hiding this comment.
@snktshrma, thanks for this. Can you change the commit to be, "Tools: add gazebo to install-ROS-ubuntu script" (or something similar).
snktshrma
changed the title
|
Sure @rmackay9 sir! I changed it to "Tools: add ardupilot_gazebo to install-ROS-ubuntu script" |
rmackay9
reviewed
Sep 9, 2022
| @@ -209,6 +209,16 @@ heading "${green}Initializaing rosdep${reset}" | |||
| sudo rosdep init || true | |||
| # To find available packages, use: | |||
| rosdep update | |||
|
|
|||
| # Installing ardupilot_gazebo | |||
| git clone https://github.com/SwiftGust/ardupilot_gazebo | |||
There was a problem hiding this comment.
shouldn't this be "ArduPilot" instead of "SwiftGust"?
There was a problem hiding this comment.
Sir the ArduPilot's package for ardupilot_gazebo doesn't have rover model
This reverts commit d4a6956.
|
Txs for this. If you could remove the "merge" commits that would be good. |
hendjoshsr71
reviewed
Sep 9, 2022
|
Closing in favour of #21680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.