Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV64: fix import that shouldn't be relative #3223

Merged

Conversation

LiquidCat64
Copy link
Contributor

What is this fixing or adding?

Fixed an import in __init__.py that caused CV64 to not work on the Python 3.8 build.

How was this tested?

Ran a generation to make sure it worked. I didn't test the 3.8 build specifically, but it should be the same fix as #3219.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 27, 2024
@Exempt-Medic Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 27, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. LGTM (didn't test a 3.8 build)

@Berserker66 Berserker66 merged commit 9e20fa4 into ArchipelagoMW:main Apr 27, 2024
16 checks passed
@LiquidCat64 LiquidCat64 deleted the CV64_py38_frozen_import_fix branch May 15, 2024 22:23
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants