Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenRCT2: Implement New Game #3229

Open
wants to merge 180 commits into
base: main
Choose a base branch
from

Conversation

Crazycolbster
Copy link

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

What is this fixing or adding?

Adds support for OpenRCT2.

How was this tested?

Over the past 6 months, we've had several public beta tests, fixing many issues.

If this makes graphical changes, please attach screenshots.

image
image
image

Crazycolbster and others added 30 commits July 3, 2023 18:31
Set up some options. Likely many, many errors
Created options and some funcitons. Likely many, many errors
The program now generates an OpenRCT2 World without logic
Fixed Bug where items wouldn't generate
Added new categories to the item list
Improved Options
Coming to realise __init__ needs to be redone
New items algorithm
Added options for random scenario from game/expansion pack
Started rule generation algorithm
Crazycolbster and others added 2 commits June 11, 2024 14:27
Gravity Gardens won't be rolled with the random scenario option
@Crazycolbster Crazycolbster marked this pull request as ready for review June 11, 2024 02:38
option_full = LocationBalancingMode.full.value
default = LocationBalancingMode.compromise.value

class SelectedScenario(Choice):

This comment was marked as resolved.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through it pretty recently. I think everything looks good!

@Exempt-Medic
Copy link
Member

Don't forget to update Readme.md and CODEOWNERS

@Exempt-Medic
Copy link
Member

What are the .gitignore changes for?

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at Client.py, the socket, or the unit test. I looked through the rest of the files, although I'll need to look at __init__.py again later, since I got a bit lost. Various comments, I have not done generations yet

worlds/openrct2/data/scenarios.json Show resolved Hide resolved
worlds/openrct2/data/scenarios.json Outdated Show resolved Hide resolved
worlds/openrct2/docs/en_OpenRCT2.md Show resolved Hide resolved
worlds/openrct2/docs/en_OpenRCT2.md Outdated Show resolved Hide resolved
worlds/openrct2/docs/en_OpenRCT2.md Outdated Show resolved Hide resolved
worlds/openrct2/__init__.py Show resolved Hide resolved
worlds/openrct2/Options.py Outdated Show resolved Hide resolved
worlds/openrct2/Options.py Show resolved Hide resolved
worlds/openrct2/__init__.py Show resolved Hide resolved
worlds/openrct2/Options.py Outdated Show resolved Hide resolved
@Exempt-Medic Exempt-Medic added the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Aug 20, 2024
@Exempt-Medic Exempt-Medic removed the waiting-on: author Issue/PR is waiting for feedback or changes from its author. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: new game Pull requests for implementing new games into Archipelago. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants