Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Messenger: fix import that shouldn't be relative #3219

Merged
merged 1 commit into from
Apr 26, 2024
Merged

The Messenger: fix import that shouldn't be relative #3219

merged 1 commit into from
Apr 26, 2024

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

An incorrect import that breaks the 3.8 build

How was this tested?

Rebuilt and checked that the world loads

If this makes graphical changes, please attach screenshots.

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 26, 2024
Ixrec
Ixrec approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@Ixrec Ixrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change lgtm

black-sliver
black-sliver approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Those are easy to miss - I think we really need the apworld analyzer script :S
(Even if we drop 3.8, the absolute import is more sane if we have ever change something in the world import system in the future.)

@black-sliver black-sliver merged commit 4f1e696 into ArchipelagoMW:main Apr 26, 2024
16 checks passed
@alwaysintreble alwaysintreble deleted the oops_i_did_it_again branch April 26, 2024 19:34
@LiquidCat64 LiquidCat64 mentioned this pull request Apr 27, 2024
Merged
jnschurig pushed a commit to Tranquilite0/Archipelago-SoulBlazer that referenced this pull request Jun 13, 2024
@alwaysintreble
The Messenger: fix import that shouldn't be relative (ArchipelagoMW#3219
1d2bb72 
)
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@alwaysintreble @qwint
The Messenger: fix import that shouldn't be relative (ArchipelagoMW#3219
610a80a 
)
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
@alwaysintreble @AustinSumigray
The Messenger: fix import that shouldn't be relative (ArchipelagoMW#3219
9525ea8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

@Ixrec Ixrec Ixrec approved these changes

Assignees
No one assigned
Labels
waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwaysintreble @Ixrec @black-sliver