Yoshi's Island: Implement New Game

[PinkSwitch]

What is this fixing or adding?

Adds Archipelago support for the SNES version of Yoshi’s Island.

How was this tested?

Multiple sessions of public and private tests, and instances of unsupported game tests with Yoshi’s Island outside of the Archipelago Server.

If this makes graphical changes, please attach screenshots.

N/A.

[NewSoupVi]

Alright, time for my actual approval.

Here is what I reviewed:

• I did a full review of this a long time ago, I believe most of my most obvious complaints from back then got addressed.
• In the last few days, I did another pass on all the files and personally fixed a lot of the style violations (with @Exempt-Medic double checking that I didn't screw something up in the process). There's still some line length stuff, but it's stuff I'm ok with, i.e. it's on par with other worlds now, more or less
• I generated 200 fully random seeds

Here's what I didn't do:

• I didn't play any seeds
• I didn't review the functionality of Rom.py nor Client.py

I am personally okay with this being merged in the state it is in now.

However, I do have one caveat (Sorry PinkSwitch :D).
I am still unhappy with the general inefficiency of a lot of the logic functions in level_logic.py. I would like to see that addressed in a future PR. Basically, I would like to see things like this:

def bowserdoor_3(self, state: CollectionState) -> bool:
    if self.game_logic == "Easy":
        return True
    elif self.game_logic == "Normal":
        return True
    else:
        return True

Changed to:

def bowserdoor_3(self, _: CollectionState) -> bool:
    # Never requires anything
    return True

There are many instances of inefficiencies like this in the code, not just in level_logic.py, although I'm most unhappy with it in level_logic.py because these functions are called from access rules, so they should be as optimised as possible.
Some of those things are gonna come down to experience coding in Python so I don't wanna be too harsh about it. I also know that I'm way more anal about access rule efficiency than most people.
And, this game generates very fast in its current state (0.05s fill + 0.3s rom output) that I'm willing to let it go. Hopefully these things also get optimised out in the frozen build, so it won't affect the average user as much.

Looking forward to actually playing this game in either this version or hopefully the next one at the latest.

[LiquidCat64]

Re-approving because I felt like things changed enough that I should. I genned another 1,000 fully random Yoshi stampede multi on the current up-to-date branch and it came out just as fine as the first one did.

[ScipioWright]

You should ask these in the discord instead, not on the merged PR

[Cl4rens]

Could you use the original names here aswell?
"Egg Launcher" -> "Arrow Cloud"
"Egg Refill Plant" -> "Egg Plant"

[ScipioWright]

You should ask these in the discord instead, not on the merged PR