Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release App (PATCH) #420

Merged
merged 26 commits into from
Apr 23, 2023
Merged

Release App (PATCH) #420

merged 26 commits into from
Apr 23, 2023

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Apr 11, 2023

This release includes various app improvements, bug fixes, and updates to address issues.

Changes

The following commits/pull requests are part of this release:

App improvements:

Bug fixes:

Code improvements, maintenance, and other chores:

Technical debt

Commits in this PR has introduced the following issues to the codebase:

marfavi and others added 21 commits November 29, 2022 18:08
* reconsider some todos
* remove responses from mobilepay_service
…e (Clean Architecture); Use dartz package for Either class (#394)

Co-authored-by: Omid Marfavi <[email protected]>
Co-authored-by: fremartini <[email protected]>
Co-authored-by: Omid Marfavi <[email protected]>
Co-authored-by: Frederik Petersen <[email protected]>
* Update gitignore

* work on flavors

* wip

to do: fix CODE_SIGN_STYLE, DEVELOPMENT_TEAM in some instances in
project.pbxproj

* add back ipad support

* wip

* adjust run configs in .idea/

* update run/launch configs

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* update Firebase iOS dev project

* update android dev project + dev app id

* whitespace

* add splash

* add profile mode in launch/run config

* add dev icons; add splash; finishing touches

* temp (for test) force is_prod = true

* temp (for test) force upload to firebase app dist

* temp (for test)

* fix android build path

* Change documentation in pubspec.yaml

* Test Dev build

* Test Dev build

* Add Secrets documentation

* Test Dev release

* Test prod release

* Add back ipad support

* Save

* Readd lock file

* Cleanup pipeline

* Remove debug trigger

* Change storeArtificats to default to false

---------

Co-authored-by: Jonas Anker Rasmussen <[email protected]>
Co-authored-by: Frederik Petersen <[email protected]>
* Removed http_utils, functionality has already been replacedd by ServerFailure

* Fixed a test for loginCubit
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #420 (fa44816) into production (2605af5) will increase coverage by 12.48%.
The diff coverage is 56.50%.

@@               Coverage Diff               @@
##           production     #420       +/-   ##
===============================================
+ Coverage       41.54%   54.02%   +12.48%     
===============================================
  Files              56       74       +18     
  Lines             804      881       +77     
===============================================
+ Hits              334      476      +142     
+ Misses            470      405       -65     
Flag Coverage Δ
unittests 54.02% <56.50%> (+12.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/core/usecases/usecase.dart 0.00% <0.00%> (ø)
lib/cubits/contributor/contributor_state.dart 100.00% <ø> (ø)
.../repositories/external/contributor_repository.dart 0.00% <0.00%> (ø)
lib/data/repositories/v1/product_repository.dart 0.00% <0.00%> (ø)
lib/data/repositories/v1/voucher_repository.dart 0.00% <0.00%> (ø)
...ib/data/repositories/v2/app_config_repository.dart 0.00% <0.00%> (ø)
...b/data/repositories/v2/leaderboard_repository.dart 0.00% <0.00%> (ø)
lib/data/repositories/v2/purchase_repository.dart 0.00% <0.00%> (ø)
lib/data/repositories/v2/receipt_repository.dart 0.00% <0.00%> (ø)
lib/models/account/update_user.dart 12.50% <0.00%> (+12.50%) ⬆️
... and 42 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fremartini and others added 5 commits April 15, 2023 20:15
@TTA777
Copy link
Member

TTA777 commented Apr 20, 2023

@marfavi The changelog seems to indicate a couple of open issues have been solved and are crediting people for doing so when they simply mentioned those issued. I guess it's due to how the changelog was generated, but can we fix that before merging?

@marfavi marfavi requested a review from TTA777 April 23, 2023 13:04
Copy link
Member

@TTA777 TTA777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marfavi marfavi merged commit 9977294 into production Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants