Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing error in validation logic of form_bloc #398

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

TTA777
Copy link
Member

@TTA777 TTA777 commented Feb 17, 2023

A fix for the error reported by @marfavi

Testing has been minimal due to working from the train, but it appears to work as intended on my phone

@TTA777 TTA777 requested review from marfavi and a team February 17, 2023 14:59
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #398 (9e94ec0) into develop (cbb4ff4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #398   +/-   ##
========================================
  Coverage    48.16%   48.16%           
========================================
  Files           87       87           
  Lines         1472     1472           
========================================
  Hits           709      709           
  Misses         763      763           
Flag Coverage Δ
unittests 48.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fremartini fremartini merged commit 9e7178b into develop Feb 21, 2023
@fremartini fremartini deleted the fix/tta/formBloc branch February 21, 2023 15:00
@marfavi marfavi mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants