Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UI tests #355

Merged
merged 14 commits into from
Dec 6, 2022
Merged

add UI tests #355

merged 14 commits into from
Dec 6, 2022

Conversation

fredpetersen
Copy link
Contributor

@fredpetersen fredpetersen commented Nov 1, 2022

closes #303

@fredpetersen fredpetersen requested a review from a team November 1, 2022 18:20
@fredpetersen fredpetersen self-assigned this Nov 1, 2022
@fredpetersen fredpetersen marked this pull request as draft November 1, 2022 18:20
@marfavi marfavi force-pushed the feature/frepe/ui-tests branch from b1c592c to f3a2144 Compare November 15, 2022 08:16
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #355 (1602119) into develop (100b619) will increase coverage by 6.17%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #355      +/-   ##
===========================================
+ Coverage    41.70%   47.88%   +6.17%     
===========================================
  Files           56       77      +21     
  Lines          808     1395     +587     
===========================================
+ Hits           337      668     +331     
- Misses         471      727     +256     
Flag Coverage Δ
unittests 47.88% <100.00%> (+6.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/widgets/pages/settings/setting_value_text.dart 100.00% <100.00%> (ø)
lib/widgets/components/helpers/tappable.dart 100.00% <0.00%> (ø)
lib/widgets/components/images/coffee_image.dart 100.00% <0.00%> (ø)
...dgets/components/stats/leaderboard_list_entry.dart 97.82% <0.00%> (ø)
lib/widgets/components/user/user_icon.dart 92.85% <0.00%> (ø)
.../components/tickets/bottom_modal_sheet_helper.dart 0.00% <0.00%> (ø)
lib/widgets/components/error_section.dart 100.00% <0.00%> (ø)
lib/widgets/components/tickets/rounded_button.dart 95.00% <0.00%> (ø)
lib/widgets/components/tickets/coffee_card.dart 84.37% <0.00%> (ø)
...b/widgets/components/tickets/buy_tickets_card.dart 96.29% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fredpetersen fredpetersen marked this pull request as ready for review November 15, 2022 16:27
@fredpetersen fredpetersen marked this pull request as draft November 15, 2022 16:36
@fredpetersen fredpetersen marked this pull request as ready for review November 22, 2022 15:34
@fremartini fremartini force-pushed the feature/frepe/ui-tests branch from b27fee7 to 6ea6f53 Compare November 22, 2022 17:53
@fremartini fremartini force-pushed the feature/frepe/ui-tests branch from 68a6df3 to 1057bae Compare December 6, 2022 15:25
@fremartini fremartini merged commit 75600de into develop Dec 6, 2022
@fremartini fremartini deleted the feature/frepe/ui-tests branch December 6, 2022 15:58
@marfavi marfavi mentioned this pull request Feb 14, 2023
marfavi added a commit that referenced this pull request Feb 15, 2023
* Improve time since utility (#376)

* add additional team members to credits (#379)

* misc: addd `make clean` command (#375)

* add UI tests (#355)

* Remove todos (#388)

* reconsider some todos
* remove responses from mobilepay_service

* Fix for OpeningHoursIndicator, so it now behaves as expected on errors (#389)

* fix error (#392)

* Update OpenApi with latest changes (#390)

* set programme on register (#381)

Co-authored-by: Omid Marfavi <[email protected]>

* Hide open indicator on API error; Move opening hours code into feature (Clean Architecture); Use dartz package for Either class (#394)

Co-authored-by: Omid Marfavi <[email protected]>

---------

Co-authored-by: Frederik Martini <[email protected]>
Co-authored-by: Frederik Petersen <[email protected]>
Co-authored-by: Thomas Andersen <[email protected]>
Co-authored-by: Jonas Anker Rasmussen <[email protected]>
@marfavi marfavi mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write UI tests
3 participants