Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher): authenticate with drupal #86

Merged
merged 45 commits into from
Nov 1, 2023
Merged

Conversation

colorfield
Copy link
Member

@colorfield colorfield commented Jun 28, 2023

Description of changes

Keep only project specific configuration to integrate AmazeeLabs/silverback-mono#1339

SLB-176

Motivation and context

Better DX

How has this been tested?

  • Manually
  • Unit tests
  • Integration tests

@colorfield colorfield requested review from Leksat and pmelab June 28, 2023 16:05
Copy link
Member

@Leksat Leksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated all the things (#89) so there are conflicts now. Sorry 😅

apps/cms/scaffold/settings.php.append.txt Show resolved Hide resolved
apps/website/publisher.config.ts Outdated Show resolved Hide resolved
@colorfield colorfield changed the base branch from dev to release October 16, 2023 09:56
chore: modify post-rollout path

Revert "chore: use private scheme for keys due to infra limitations"

This reverts commit 9bc191c.

Revert "chore: modify post-rollout path"

This reverts commit d069abf.

Revert "Revert "chore: modify post-rollout path""

This reverts commit a2f05d1.

Revert "Revert "chore: use private scheme for keys due to infra limitations""

This reverts commit 6cde70a.
Copy link
Member

@Leksat Leksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions + hook_file_download and we are good to go 🚀

apps/cms/config/sync/user.role.publisher.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Leksat Leksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge after improving custom_file_download 🙏 🎉

packages/drupal/custom/custom.module Show resolved Hide resolved
Removes the need of the publisher scope
@colorfield colorfield merged commit f7fa83e into release Nov 1, 2023
2 checks passed
@colorfield colorfield deleted the publisher-oauth branch November 1, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants