Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove oauth scope for publisher auth code #1450

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

colorfield
Copy link
Member

Package(s) involved

publisher

Description of changes

Removed default publisher scope for AuthorizationCode grant type as we are removing the default Publisher role in AmazeeLabs/silverback-template#86

It's still set in the Publisher configuration if we want to use ResourceOwnerPassword grant type.

Motivation and context

Make OAuth work without the scope being set in the Consumer.
Access is checked based on the current user permission.

How has this been tested?

Manually.

@colorfield colorfield requested a review from Leksat November 1, 2023 15:47
@colorfield colorfield merged commit 1f6fd7e into development Nov 1, 2023
3 checks passed
@colorfield colorfield deleted the oauth-publisher-scope branch November 1, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants