feat(publisher): Authenticate Publisher with Drupal #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colorfield
changed the title
|
| Prod Packages | Operation | Base | Target |
|---|---|---|---|
| defuse/php-encryption | New | - | v2.3.1 |
| drupal/consumers | New | - | 1.17.0 |
| drupal/simple_oauth | New | - | 5.2.3 |
| lcobucci/clock | New | - | 3.0.0 |
| lcobucci/jwt | New | - | 4.3.0 |
| league/event | New | - | 2.2.0 |
| league/oauth2-server | New | - | 8.5.1 |
| league/uri | New | - | 6.8.0 |
| league/uri-interfaces | New | - | 2.3.0 |
| paragonie/random_compat | New | - | v9.99.100 |
| psr/clock | New | - | 1.0.0 |
| steverhoades/oauth2-openid-connect-server | New | - | v2.5.0 |
colorfield
force-pushed
the
publisher-auth
branch
from
0388006 to
aaf9814
Compare
This is needed to prevent https://www.drupal.org/project/simple_oauth/issues/3255346
colorfield
force-pushed
the
publisher-auth
branch
from
5b55dba to
c325d37
Compare
…res authentication
# Conflicts: # packages/composer/amazeelabs/silverback_gatsby/silverback_gatsby.routing.yml # packages/npm/@amazeelabs/publisher/package.json # pnpm-lock.yaml
pmelab
approved these changes
Jun 27, 2023
|
Going to create a PR in the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package(s) involved
Description of changes
OAuth2 middleware that is checking if a Drupal user has the
Access Publisherpermission to grant access to Express authenticated routes.Grant types
AuthorizationCodeResourceOwnerPasswordKeeps BC with existing
Basic Auth: provides a configurable way, so nothing will change on existing setups unlessOAuth2is configured.Opens the possibility to generalise OAuth2 for other use cases: Instant preview, Gatsby sourcing, end user or other APIs authentication.
Documentation for Publisher and Drupal configuration.
TBD
Drupal
Publisherscope/role might be a bit too generic and potentially conflict with editorial related roles. Perhaps choose thePublisher Buildername.Remaining tasks
Motivation and context
https://amazeelabs.atlassian.net/browse/SLB-176
Related Issue(s)
#1137
How has this been tested?
Manually.