Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLB-269: finish multilingual features #139

Merged
merged 36 commits into from
Feb 19, 2024
Merged

SLB-269: finish multilingual features #139

merged 36 commits into from
Feb 19, 2024

Conversation

pmelab
Copy link
Contributor

@pmelab pmelab commented Feb 13, 2024 •
edited
Loading

Description of changes

  • Make content hub react to the current language
  • Add a simple language switcher
  • Add interface translations to decap
  • Add interface translations to drupal
  • Integration tests for all of these

Note: This contains copies for files from AmazeeLabs/silverback-mono#1494. As soon as it is merged, they will be removed from here.

Motivation and context

Make the starter kit fully multilingual. With Drupal as well as Decap

How has this been tested?

  • Manually
  • Unit tests
  • Integration tests

@pmelab pmelab force-pushed the SLB-269-multilingual-features branch from 765cb19 to b715837 Compare February 13, 2024 20:58
pmelab added 29 commits February 16, 2024 15:01
@pmelab
feat(SLB-269): add locale arguments to content hub schema
015df10
@pmelab
fix: clear content hub queries on all node changes
f124738
@pmelab
feat(SLB-269): implement content hub locale filter in drupal
7bdb805
@pmelab
feat(SLB-269): pass current locale into content hub operation
c8d4461
@pmelab
feat(SLB-269): render a content hub page for each language
7835ca2
@pmelab
test(SLB-269): multilingual content hub integration test
164d30a
@pmelab
feat(SLB-269): translations context for dynamically updating the lang…
c4e212f 
…uage switcher
@pmelab
feat(SLB-269): add language switcher component
ddb5bd5
@pmelab
feat(SLB-269): initialize the language switcher from routes
2c185c4
@pmelab
refactor: remove leftover debug log
b7572b4
@pmelab
test(SLB-269): language switcher integration tests
ba6c2c6
@pmelab
test: add content hub full page story
bfe1a89
@pmelab
fix: wrong footer navigation
8fe8341
@pmelab
test: menu integration tests
7150934
@pmelab
chore(SLB-269): upgrade @amazeelabs/gatsby-source-silverback
df69c17 
To get AmazeeLabs/silverback-mono@4366150
@pmelab
test(SLB-269): example data for a multilingual decap page
3282caf
@pmelab
fix(SLB-269): make decap page sourcing compatible to multilingual pages
e4015b5 
Id's need to be handled differently, since they are shared by translations and only appear in one.
@pmelab
feat(SLB-269): gatsby directive to retrieve decap translations
403c2fb
@pmelab
test(SLB-269): integration tests for translated decap pages
deb45ea
@pmelab
feat(SLB-269): import translations when prepping database
ccb4a12
@pmelab
feat(SLB-269): translate interface strings in decap
0e42a37
@pmelab
feat(SLB-269): graphql schema for translatable strings
30ad655
@pmelab
refactor: upgrade graphql directives module and use simpler @value di…
faab9ad 
…rective
@pmelab
feat(SLB-269): source translatable strings into gatsby datastore
ab1e6fe
@pmelab
feat(SLB-269): inject translation strings into ui
da0e975
@pmelab
test(SLB-269): integration tests for translation strings
4d663d7
@pmelab
refactor: fix wrong variable naming in menu integration test
cc66d7a
@pmelab
test(SLB-269): integration tests for translation strings
9379a3f
@pmelab
chore(SLB-269): update @amazeelabs/gatsby-source-silverback
5e4447d 
To get the "translation" field fix.
AmazeeLabs/silverback-mono@4674cc3
@pmelab pmelab force-pushed the SLB-269-multilingual-features branch from 0f830dd to 378c95c Compare February 16, 2024 14:04
@pmelab pmelab force-pushed the SLB-269-multilingual-features branch from d3959f0 to ec9e50e Compare February 16, 2024 14:33
@pmelab pmelab marked this pull request as ready for review February 16, 2024 14:53
Leksat
Leksat reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@Leksat Leksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the UI Test failure is a real one :)

apps/cms/prep-database.sh Show resolved Hide resolved
@pmelab pmelab mentioned this pull request Feb 19, 2024
Closed
3 tasks
@pmelab
Copy link
Contributor Author

pmelab commented Feb 19, 2024

I think the UI Test failure is a real one :)

It is not 😛

@pmelab pmelab merged commit 6103b24 into release Feb 19, 2024
4 checks passed
@pmelab pmelab deleted the SLB-269-multilingual-features branch February 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leksat Leksat Leksat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmelab @Leksat