Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface translations #76

Closed
wants to merge 2 commits into from
Closed

Interface translations #76

wants to merge 2 commits into from

Conversation

chindris
Copy link
Contributor

@chindris chindris commented May 27, 2023

Description of changes

Feeds the react intl provider with translations from the CMS

Related issues

#52

How has this been tested?

  • Manually
  • Unit tests
  • Integration tests (there's still a todo left)

@chindris
Copy link
Contributor Author

@pmelab There are a couple of integration tests for this, but we actually need to have a test database with translations added. Previously we used to have a install-cache zip which we could update and it was used for such cases. Not sure what is the workflow now, and how we'd handle this case. We could of course have some kind of an import script, like we have for default content, is that what we should do?

@chindris chindris requested a review from pmelab May 27, 2023 07:07
@pmelab
Copy link
Contributor

pmelab commented Feb 19, 2024

this is solved slightly different in #139

@pmelab pmelab closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants