-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/convert-to-npe2 #49
Conversation
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 83.59% 88.77% +5.17%
==========================================
Files 7 3 -4
Lines 189 187 -2
==========================================
+ Hits 158 166 +8
+ Misses 31 21 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single comment otherwise looks good to me!
python_name: napari_aicsimageio.core:get_reader | ||
readers: | ||
- command: napari-aicsimageio.get_reader | ||
filename_patterns: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rough but understandable. Should become easier to generate in aicsimageio v5 though because plugins report which filetypes they support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not strictly necessary... we could also use filename_patterns: ["*"]
... but this is preferable, as it will allow napari to do things like this make suggestions to a user that doesn't have aicsimageio installed that "there's a plugin that can help with this"
Wait even my comment is ignorable. Merging now! |
converts plugin to npe2 (docs on creating npe2 plugins)
As discussed on zulip, the biggest impact for this plugin is the inability to have two virtual plugin entry points (in/out of mem) within a single plugin package. while we can provide multiple readers in a single plugin, we discussed that it might be better to just choose based on the filesize/memory available. I did that here with a 30% available mem or 4GB file size threshold. Seems to work well in local tests
this also: