Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current sdist broken :/ lacking manifest #53

Closed
tlambert03 opened this issue Jul 24, 2022 · 3 comments
Closed

current sdist broken :/ lacking manifest #53

tlambert03 opened this issue Jul 24, 2022 · 3 comments

Comments

@tlambert03
Copy link
Contributor

Description

Looks like the sdist (but not the wheel) for v0.7.0 is lacking the napari.yaml manifest. This means that pip installs will work, but conda installs will not (since conda rebuilds from the sdist). I could have sworn I checked for this in #49 ... but I dunno, maybe I looked at the wheel?

Anyway, I just double checked that on main, if you run python -m build, both the sdist and wheel archives that get dropped into the dist/ folder contain the napari.yaml file (and now we also have check-manifest tests, which will also make sure of it). So @evamaxfield ... would you mind releasing 0.7.1?
@tlambert03 tlambert03 changed the title current dist broken :/ lacking manifest current sdist broken :/ lacking manifest Jul 24, 2022
@evamaxfield
Copy link
Collaborator

I'm out for the day. Will release later tonight!

@tlambert03
Copy link
Contributor Author

no worries! :) enjoy your day

@evamaxfield
Copy link
Collaborator

Had to update the bumpversion.cfg but v0.7.1 was just pushed. Should be out within ~30 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tlambert03 @evamaxfield