Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/cleanup-np2 #50

Merged
merged 2 commits into from
Jul 21, 2022
Merged

feature/cleanup-np2 #50

merged 2 commits into from
Jul 21, 2022

Conversation

evamaxfield
Copy link
Collaborator

Minor cleanup for the prior PR (#49)

  • Fix README discussion around plugin variants
  • Use fsspec stat size instead of Path stat size to allow remote reading.
    • Note: this doesn't handle fs_kwargs like base aicsimageio does so something for users to be aware of.

cc @tlambert03

@evamaxfield evamaxfield added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 21, 2022
@evamaxfield evamaxfield self-assigned this Jul 21, 2022
tlambert03
tlambert03 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evamaxfield evamaxfield merged commit fc545b0 into main Jul 21, 2022
@evamaxfield evamaxfield deleted the feature/cleanup-npe2 branch July 21, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlambert03 tlambert03 tlambert03 approved these changes

Assignees

@evamaxfield evamaxfield

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evamaxfield @tlambert03