Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support success policy for TFJob #26

Conversation

ChenYi015
Copy link
Collaborator

@ChenYi015 ChenYi015 commented Sep 20, 2024

Cherry pick commits from kubeflow#1165.

@ChenYi015
Copy link
Collaborator Author

CC @cheyang @happy2048 @Syulin7

@ChenYi015 ChenYi015 force-pushed the feature/success-policy branch from 3ff3e10 to 6aef3ef Compare September 20, 2024 03:27
@ChenYi015 ChenYi015 changed the title Add successPolicy to TFJob Support success policy for TFJob Sep 20, 2024
@ChenYi015 ChenYi015 force-pushed the feature/success-policy branch 3 times, most recently from 7a49670 to b8a12fd Compare September 20, 2024 06:12
pkg/controller.v1/tensorflow/status.go Outdated Show resolved Hide resolved
pkg/apis/tensorflow/v1/types.go Show resolved Hide resolved
pkg/controller.v1/tensorflow/status.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ChenYi015 ChenYi015 marked this pull request as draft September 27, 2024 06:15
@cheyang cheyang self-requested a review September 27, 2024 07:27
@ChenYi015 ChenYi015 force-pushed the feature/success-policy branch from b8a12fd to d1fa953 Compare September 29, 2024 06:25
@ChenYi015 ChenYi015 marked this pull request as ready for review September 29, 2024 06:52
pkg/apis/tensorflow/v1/common.go Outdated Show resolved Hide resolved
terrytangyuan and others added 4 commits September 29, 2024 15:16
* Support success policy for TFJob

Signed-off-by: terrytangyuan <[email protected]>

* Fix imports

Signed-off-by: terrytangyuan <[email protected]>

* Update generated code

Signed-off-by: terrytangyuan <[email protected]>

* Fix defaults_test.go

Signed-off-by: terrytangyuan <[email protected]>
(cherry picked from commit 2479837)
Signed-off-by: Yi Chen <[email protected]>
@ChenYi015 ChenYi015 force-pushed the feature/success-policy branch from 0d0a26d to b39166e Compare September 29, 2024 07:17
@ChenYi015 ChenYi015 requested a review from cheyang September 29, 2024 07:18
@cheyang cheyang merged commit a0bb318 into AliyunContainerService:v1.0-aliyun-branch Sep 29, 2024
@ChenYi015 ChenYi015 deleted the feature/success-policy branch September 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants