forked from kubeflow/training-operator
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support success policy for TFJob #26
Merged
cheyang
merged 4 commits into
AliyunContainerService:v1.0-aliyun-branch
from
ChenYi015:feature/success-policy
Sep 29, 2024
Merged
Support success policy for TFJob #26
cheyang
merged 4 commits into
AliyunContainerService:v1.0-aliyun-branch
from
ChenYi015:feature/success-policy
Sep 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenYi015
force-pushed
the
feature/success-policy
branch
from
September 20, 2024 03:27
3ff3e10
to
6aef3ef
Compare
ChenYi015
changed the title
Add successPolicy to TFJob
Support success policy for TFJob
Sep 20, 2024
ChenYi015
force-pushed
the
feature/success-policy
branch
3 times, most recently
from
September 20, 2024 06:12
7a49670
to
b8a12fd
Compare
happy2048
reviewed
Sep 20, 2024
cheyang
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
ChenYi015
force-pushed
the
feature/success-policy
branch
from
September 29, 2024 06:25
b8a12fd
to
d1fa953
Compare
cheyang
requested changes
Sep 29, 2024
* Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yi Chen <[email protected]>
ChenYi015
force-pushed
the
feature/success-policy
branch
from
September 29, 2024 07:17
0d0a26d
to
b39166e
Compare
cheyang
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick commits from kubeflow#1165.