Support success policy for TFJob #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: terrytangyuan <[email protected]>
|
This change is |
|
/cc @gaocegege @ChanYiLin |
Travis tests have failedHey @terrytangyuan, 2nd Buildhack/verify-codegen.shgo build -o tf-operator.v1 github.com/kubeflow/tf-operator/cmd/tf-operator.v1golangci-lint run ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/*.go,pkg/util/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: 488d6dc0-a01f-11ea-aa49-9d3926c79f60 |
Signed-off-by: terrytangyuan <[email protected]>
Travis tests have failedHey @terrytangyuan, 2nd Buildhack/verify-codegen.shgoveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/*.go,pkg/util/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: e159b8e0-a021-11ea-aa49-9d3926c79f60 |
Signed-off-by: terrytangyuan <[email protected]>
Travis tests have failedHey @terrytangyuan, 2nd Buildgoveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/*.go,pkg/util/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: d0990450-a023-11ea-aa49-9d3926c79f60 |
Signed-off-by: terrytangyuan <[email protected]>
|
/retest |
1 similar comment
|
/retest |
|
/test kubeflow-tf-operator-presubmit |
|
The feature LGTM. But the name And, should we keep the policy in common? /cc @Jeffwan |
|
I was thinking about moving this to Kubeflow/common as well but we need to see whether other operators have the same demands before doing that. Also it would take more time to switch to use the most recent Kubeflow/common so it’s better to keep this here for now. |
|
BTW, Is there the situation that the chief worker is succeeded but the one of the worker fails? |
|
Yes that is the use case. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
|
@terrytangyuan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ChenYi015
pushed a commit
to ChenYi015/training-operator
that referenced
this pull request
Sep 20, 2024
* Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]>
ChenYi015
pushed a commit
to ChenYi015/training-operator
that referenced
this pull request
Sep 20, 2024
* Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]>
ChenYi015
pushed a commit
to ChenYi015/training-operator
that referenced
this pull request
Sep 20, 2024
* Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]>
ChenYi015
pushed a commit
to ChenYi015/training-operator
that referenced
this pull request
Sep 20, 2024
* Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]>
ChenYi015
pushed a commit
to ChenYi015/training-operator
that referenced
this pull request
Sep 29, 2024
* Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]>
ChenYi015
pushed a commit
to ChenYi015/training-operator
that referenced
this pull request
Sep 29, 2024
* Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]>
cheyang
pushed a commit
to AliyunContainerService/tf-operator
that referenced
this pull request
Sep 29, 2024
* Support success policy for TFJob (kubeflow#1165) * Support success policy for TFJob Signed-off-by: terrytangyuan <[email protected]> * Fix imports Signed-off-by: terrytangyuan <[email protected]> * Update generated code Signed-off-by: terrytangyuan <[email protected]> * Fix defaults_test.go Signed-off-by: terrytangyuan <[email protected]> (cherry picked from commit 2479837) Signed-off-by: Yi Chen <[email protected]> * Add validation for non-nil pointer Signed-off-by: Yi Chen <[email protected]> * Add kubebuilder marker for validating success policy Signed-off-by: Yi Chen <[email protected]> * Add make target generate Signed-off-by: Yi Chen <[email protected]> --------- Signed-off-by: terrytangyuan <[email protected]> Signed-off-by: Yi Chen <[email protected]> Co-authored-by: Yuan Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: terrytangyuan [email protected]