Rename SuccessPolicyDefault to SuccessPolicyChiefWorker

Signed-off-by: Yi Chen <[email protected]>
AliyunContainerService · Sep 29, 2024 · d1fa953 · d1fa953
1 parent 402e567
commit d1fa953
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/pkg/apis/tensorflow/v1/common.go b/pkg/apis/tensorflow/v1/common.go
@@ -18,6 +18,6 @@ package v1
 type SuccessPolicy string
 
 const (
-	SuccessPolicyDefault    SuccessPolicy = ""
-	SuccessPolicyAllWorkers SuccessPolicy = "AllWorkers"
+	SuccessPolicyChiefWorker SuccessPolicy = "ChiefWorker"
+	SuccessPolicyAllWorkers  SuccessPolicy = "AllWorkers"
 )
diff --git a/pkg/apis/tensorflow/v1/defaults.go b/pkg/apis/tensorflow/v1/defaults.go
@@ -18,7 +18,7 @@ import (
 	"strings"
 
 	common "github.com/kubeflow/tf-operator/pkg/apis/common/v1"
-	"k8s.io/api/core/v1"
+	v1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 )
 
@@ -95,9 +95,10 @@ func SetDefaults_TFJob(tfjob *TFJob) {
 		running := common.CleanPodPolicyRunning
 		tfjob.Spec.CleanPodPolicy = &running
 	}
-	// Set default success policy to "".
+
+	// Set default success policy to ChiefWorker.
 	if tfjob.Spec.SuccessPolicy == nil {
-		defaultPolicy := SuccessPolicyDefault
+		defaultPolicy := SuccessPolicyChiefWorker
 		tfjob.Spec.SuccessPolicy = &defaultPolicy
 	}
 

diff --git a/pkg/apis/tensorflow/v1/defaults_test.go b/pkg/apis/tensorflow/v1/defaults_test.go
@@ -18,7 +18,7 @@ import (
 	"reflect"
 	"testing"
 
-	"k8s.io/api/core/v1"
+	v1 "k8s.io/api/core/v1"
 
 	common "github.com/kubeflow/tf-operator/pkg/apis/common/v1"
 	"github.com/kubeflow/tf-operator/pkg/util"
@@ -51,7 +51,7 @@ func expectedTFJob(cleanPodPolicy common.CleanPodPolicy, restartPolicy common.Re
 		)
 	}
 
-	defaultSuccessPolicy := SuccessPolicyDefault
+	defaultSuccessPolicy := SuccessPolicyChiefWorker
 
 	return &TFJob{
 		Spec: TFJobSpec{