[ACS-8688] export playwright shared lib #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysVuika
approved these changes
Aug 30, 2024
DenysVuika
reviewed
Aug 30, 2024
| ] | ||
| }, | ||
| "lint": { | ||
| "executor": "@angular-eslint/builder:lint" |
There was a problem hiding this comment.
I think it's missing some configuration, the CI/CD says "nothing to lint"
There was a problem hiding this comment.
Yes I miss to add .eslintrc.js file, will add it in next commit.
seems like there any many lint issue after adding this on local to be resolved
MichalKinas
reviewed
Sep 3, 2024
| @@ -1,7 +1,28 @@ | |||
| { | |||
| "name": "playwright-shared", | |||
There was a problem hiding this comment.
I think ng-packge file is missing
AleksanderSklorz
approved these changes
Sep 3, 2024
|
MichalKinas
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket link or change set's description
export aca-playwright-shared lib to used in ADW playwright e2e for better code reuse
https://hyland.atlassian.net/browse/ACS-8688