-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-8688] export playwright shared lib #4068
Changes from 5 commits
fdfced4
44252d8
d197363
d779fb0
5d06ca0
fb248d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
const path = require('path'); | ||
module.exports = { | ||
extends: '../../.eslintrc.json', | ||
ignorePatterns: ['!**/*'], | ||
overrides: [ | ||
{ | ||
files: ['*.ts'], | ||
parserOptions: { | ||
project: [path.join(__dirname, 'tsconfig.lib.json'), path.join(__dirname, 'tsconfig.spec.json')], | ||
createDefaultProgram: true | ||
}, | ||
rules: { | ||
'no-console': ['error', {'allow': ['info', 'log', 'warn', 'error'] }] | ||
} | ||
} | ||
] | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,28 @@ | ||
{ | ||
"name": "playwright-shared", | ||
"name": "aca-playwright-shared", | ||
"$schema": "../../node_modules/nx/schemas/project-schema.json", | ||
"sourceRoot": "projects/aca-playwright-shared/src", | ||
"projectType": "library", | ||
"prefix": "lib" | ||
"prefix": "lib", | ||
"targets": { | ||
"build": { | ||
"executor": "@angular-devkit/build-angular:ng-packagr", | ||
"options": { | ||
"tsConfig": "projects/aca-playwright-shared/tsconfig.lib.json", | ||
"project": "projects/aca-playwright-shared/ng-package.json" | ||
}, | ||
"configurations": { | ||
"production": { | ||
"tsConfig": "projects/aca-playwright-shared/tsconfig.lib.prod.json" | ||
} | ||
}, | ||
"defaultConfiguration": "production", | ||
"outputs": [ | ||
"{workspaceRoot}/dist/@alfresco/aca-playwright-shared" | ||
] | ||
}, | ||
"lint": { | ||
"executor": "@angular-eslint/builder:lint" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's missing some configuration, the CI/CD says "nothing to lint" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes I miss to add .eslintrc.js file, will add it in next commit. |
||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
ng-packge
file is missing