Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8688] export playwright shared lib #4068

Merged
merged 6 commits into from
Sep 3, 2024
Merged

[ACS-8688] export playwright shared lib #4068

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fdfced4
[ACS-8688] export playwright shared lib
akashrathod28 Aug 30, 2024
44252d8
[ACS-8688] changes name
akashrathod28 Aug 30, 2024
d197363
[ACS-8688] changes name
akashrathod28 Aug 30, 2024
d779fb0
[ACS-8688] add lint file and fix lint issue
akashrathod28 Aug 30, 2024
5d06ca0
[ACS-8688] test fix
akashrathod28 Sep 2, 2024
fb248d3
added ng package file
akashrathod28 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/publish-libs/npm-publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ fi

export PROJECTS=(
'aca-content'
'aca-shared'
'aca-shared',
'aca-playwright-shared'
);

for PROJECT in ${PROJECTS[@]}
Expand Down
3 changes: 2 additions & 1 deletion .github/actions/update-library-versions/update-lib-versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ fi

export PROJECTS=(
'aca-content'
'aca-shared'
'aca-shared',
'aca-playwright-shared'
);

for PROJECT in ${PROJECTS[@]}
Expand Down
2 changes: 1 addition & 1 deletion projects/aca-playwright-shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "aca-playwright-shared",
"name": "@alfresco/aca-playwright-shared",
"version": "3.0.0",
"license": "LGPL-3.0",
"main": "src/index.ts",
Expand Down
25 changes: 23 additions & 2 deletions projects/aca-playwright-shared/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,28 @@
{
"name": "playwright-shared",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ng-packge file is missing

"name": "aca-playwright-shared",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "projects/aca-playwright-shared/src",
"projectType": "library",
"prefix": "lib"
"prefix": "lib",
"targets": {
"build": {
"executor": "@angular-devkit/build-angular:ng-packagr",
"options": {
"tsConfig": "projects/aca-playwright-shared/tsconfig.lib.json",
"project": "projects/aca-playwright-shared/ng-package.json"
},
"configurations": {
"production": {
"tsConfig": "projects/aca-playwright-shared/tsconfig.lib.prod.json"
}
},
"defaultConfiguration": "production",
"outputs": [
"{workspaceRoot}/dist/@alfresco/aca-playwright-shared"
]
},
"lint": {
"executor": "@angular-eslint/builder:lint"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's missing some configuration, the CI/CD says "nothing to lint"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I miss to add .eslintrc.js file, will add it in next commit.
seems like there any many lint issue after adding this on local to be resolved

}
}
}
1 change: 0 additions & 1 deletion tsconfig.adf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"@alfresco/aca-shared/store": ["projects/aca-shared/store/src/public-api.ts"],
"@alfresco/aca-shared/rules": ["projects/aca-shared/rules/src/public-api.ts"],
"@alfresco/aca-content/ms-office": ["projects/aca-content/ms-office/src/public-api.ts"],
"@alfresco/aca-testing-shared": ["projects/aca-testing-shared/src/index.ts"],
MichalKinas marked this conversation as resolved.
Show resolved Hide resolved
"@alfresco/aca-content/about": ["projects/aca-content/about/src/public-api.ts"],
"@alfresco/aca-content/folder-rules": ["projects/aca-content/folder-rules/src/public-api.ts"],
"@alfresco/aca-content": ["projects/aca-content/src/public-api.ts"],
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"@alfresco/aca-shared": ["projects/aca-shared/src/public-api.ts"],
"@alfresco/aca-shared/rules": ["projects/aca-shared/rules/src/public-api.ts"],
"@alfresco/aca-shared/store": ["projects/aca-shared/store/src/public-api.ts"],
"@alfresco/aca-testing-shared": ["projects/aca-testing-shared/src/index.ts"],
"@alfresco/playwright-shared": ["projects/aca-playwright-shared/src/index.ts"],
"package.json": ["package.json"]
}
Expand Down
Loading