Load Select2 via importmap #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3048 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 236 236
Lines 6332 6332
=======================================
Hits 6119 6119
Misses 213 213 ☔ View full report in Codecov by Sentry. |
We must use a module here in order to define the consts globally.
tvdeyen
force-pushed
the
select2-importmap
branch
from
4f649c0 to
2afb2d7
Compare
We have our own content css file compiled with sass cli. We do not load this file at all, so it can be removed.
tvdeyen
force-pushed
the
select2-importmap
branch
from
dfe585e to
b21cd2a
Compare
sascha-karnatz
approved these changes
Sep 23, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Bundle select2 from node modules and serve via importmap.
Notable
Needs AlchemyCMS/alchemy_i18n#68
Screenshots
Remove if no visual changes have been made.
Checklist