Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Handlebars templates from npm #3044

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Use Handlebars templates from npm #3044

merged 1 commit into from
Sep 19, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 19, 2024

What is this pull request for?

Instead of the very outdated Ruby gem we use
the currentl npm package. Providing the same
precompilation like before.

Checklist

@tvdeyen tvdeyen added this to the 8.0 milestone Sep 19, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner September 19, 2024 13:16
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (fb04559) to head (cda0815).
Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
- Coverage   96.63%   96.63%   -0.01%     
==========================================
  Files         236      236              
  Lines        6333     6332       -1     
==========================================
- Hits         6120     6119       -1     
  Misses        213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Instead of the very outdated Ruby gem we use
the currentl npm package. Providing the same
precompilation like before.
@tvdeyen tvdeyen merged commit fd611ad into main Sep 19, 2024
39 checks passed
@tvdeyen tvdeyen deleted the handlebars-npm branch September 19, 2024 14:12
@tvdeyen tvdeyen modified the milestones: 8.0, 7.4 Jan 3, 2025
@tvdeyen tvdeyen added the backport-to-7.4-stable Needs to be backported to 7.4-stable label Jan 3, 2025
@alchemycms-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
7.4-stable Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3044

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member Author

tvdeyen commented Jan 3, 2025

💚 All backports created successfully

Status Branch Result
7.4-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.4-stable Needs to be backported to 7.4-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants