Load jQuery via importmap #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still need it for select2 but we want to update and install it via node modules. In order for this to work we need to use module script tags. Since jQuery is loaded via importmap and a JS module (`alchemy_admin.js`) it execution is deferred.
The language id select is not always present (ie. if only one language is present).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3049 +/- ##
==========================================
- Coverage 96.63% 96.63% -0.01%
==========================================
Files 236 236
Lines 6332 6331 -1
==========================================
- Hits 6119 6118 -1
Misses 213 213 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Sep 23, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We still need it for select2 but we want to update and install it via
node modules.
In order for this to work we need to use module script tags. Since
jQuery is loaded via importmap and a JS module (
alchemy_admin.js)it execution is deferred.
Checklist