Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wcslog.js redirect #94

Closed
Alex-302 opened this issue Sep 3, 2020 · 6 comments
Closed

wcslog.js redirect #94

Alex-302 opened this issue Sep 3, 2020 · 6 comments

Comments

@Alex-302
Copy link
Member

Alex-302 commented Sep 3, 2020

@adguard-bot commented on Wed Sep 02 2020

Issue URL (Incorrect Blocking)

https://m.place.naver.com/my/review/5f17e09118deb00010dddd11?v=2

Comment

Username: @ab-c-d

This is caused by a rule ||naver.net/wcslog.js$domain=~m.tv.naver.com in AG tracking protection filter.

In old List-KR filter, there was a rule #%#window.wcs_add = {}; window.wcs_do = function() { }; to fix this. In current List-KR, there isn't. Instead of whitelisting for this site, one can create a redirection rule for wcslog.js as what's done for ga.js, containing this window.wcs_add = {};, window.... rule.

The information below is automatically generated. Do not delete it.

Referrer:
https://m.place.naver.com/my/5f4f5be06c3d7f733422debe

Custom userscripts:
C:\Users\SooHong\Desktop\scihub.user.js
https://gist.github.com/seanl-adg/a105f3ffbbf9a34d2c0cf54cca406289/raw/0133b70d25b6bb39048f938a36b51b5233b39c5d/github-show-recent-updated-issues-by-default.user.js
https://gist.githubusercontent.com/nanikit/6b13d447006e802b393e5598516a42e6/raw/manamoa.user.js
C:\Users\SooHong\Softwares\Web filters\naver_dict.user.js
https://userscripts.adtidy.org/release/popup-blocker/2.5/popupblocker.user.js
https://userscripts.adtidy.org/release/assistant/4.3/assistant.user.js

Screenshots

Screenshot 1

Screenshot 1

Screenshot 2

Screenshot 2

@Alex-302 Alex-302 changed the title m.place.naver.com wcslog.js redirect Sep 3, 2020
@slavaleleka slavaleleka added this to the 1.4 milestone Sep 3, 2020
@ameshkov
Copy link
Member

ameshkov commented Sep 3, 2020

What's wrong with using set-constant for that?

We could extend it and add a "noop-function" value if it isn't there already?

@Alex-302
Copy link
Member Author

Alex-302 commented Sep 3, 2020

redirect rule can be general, scriptlet - not.

@Alex-302
Copy link
Member Author

Alex-302 commented Sep 3, 2020

will replace current rules by scriptlets, and leave @@ for CB only

@slavaleleka
Copy link
Contributor

noopFunc is already supported by set-constant. but we should extend it for noopObj (empty object) and noopArr (empty array, might come in handy)

@slavaleleka
Copy link
Contributor

set-constant was extended to support emptyArr and emptyObj in v1.3.4

@AdamWr
Copy link
Member

AdamWr commented Feb 22, 2022

It looks like that set-constant is not enough now.
For example, here - AdguardTeam/AdguardFilters#111052
and here - AdguardTeam/AdguardFilters#54299

To reproduce add:

||wcs.naver.net/wcslog.js$important

to user rules and navigate to - https://privatenote.co.kr/main_studying/
Or to - https://www.adpiamall.com/home

So, maybe we could reconsider to add a redirect resource for wcslog.js?

Something like this should fix both issues:

(function () {
  window.wcs_add = {};
  window.wcs_do = function() {};
  window.wcs = {
    inflow(){},
  }
})();

@slavaleleka slavaleleka reopened this Feb 22, 2022
@adguard-bot adguard-bot reopened this Feb 22, 2022
@adguard-bot adguard-bot removed this from the 1.4 milestone Feb 22, 2022
adguard pushed a commit that referenced this issue Mar 15, 2022
Merge in ADGUARD-FILTERS/scriptlets from fix/AG-3906 to release/v1.6

Squashed commit of the following:

commit 31538d4
Merge: 9787ee7 69a8825
Author: Stanislav A <[email protected]>
Date:   Tue Mar 15 13:18:52 2022 +0300

    Merge branch 'release/v1.6' into fix/AG-3906

commit 9787ee7
Author: Stanislav A <[email protected]>
Date:   Tue Mar 15 12:50:46 2022 +0300

    fix typo

commit 807b9eb
Author: Stanislav A <[email protected]>
Date:   Tue Mar 15 12:31:54 2022 +0300

    rename & add to compatibility table

commit 045a836
Author: Stanislav A <[email protected]>
Date:   Mon Mar 14 18:47:36 2022 +0300

    add wcslog redirect
adguard pushed a commit that referenced this issue Mar 24, 2022
* commit 'c06a8e539488e1ebfcf72c85a39a0ef5b9c028bb': (32 commits)
  AG-13382 update docs, validate noopjson
  push updated dist to github while release build. AG-13356
  remove tagcommander redirect AG-11959
  add readme info about testing ad debugging AG-12716
  add artifacts to scriptlets builds AG-12487
  improve set-constant scriptlet #65 AG-149
  improve prevent-xhr scriptlet #199 AG-13007
  improve googletagservices-gpt redirect #193 AG-12767
  add wcslog redirect #94 AG-3906
  improve ati-smarttag redirect #200 AG-13141
  improve json-prune scriptlet #171 AG-11879
  fix yandex metrika on avito #198 AG-12973
  improve metrika-yandex-tag redirect #189 AG-12550
  add prebid-ads redirect #190 AG-12558
  remove no-floc scriptlet AG-12869
  add noopjson redirect. AG-12796 #195
  Revert "revert tests and fix converter again"
  revert tests and fix converter again
  add conversion test for wildcard tld AG-12636
  add prevent-element-src-loading scriptlet #180 AG-12328
  ...
adguard pushed a commit that referenced this issue Apr 15, 2022
…to master

* commit 'eeb28cf021fa35bd796cdbeab91ec4a997124940':
  specify decription for 'vmap' redirect
  specify redirects decsription examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants