Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve googletagservices-gpt #193

Closed
AdamWr opened this issue Feb 14, 2022 · 0 comments
Closed

Improve googletagservices-gpt #193

AdamWr opened this issue Feb 14, 2022 · 0 comments
Assignees
@stanislav-atr
Labels
Release: v1.6.2 Resolution: Fixed Status: Closed Version: Scriptlets v1.6

Comments

@AdamWr
Copy link
Member

AdamWr commented Feb 14, 2022

freundin.de is broken by googletagservices-gpt redirect resource.

Steps to reproduce

  1. Add this rule:
||securepubads.g.doubleclick.net/tag/js/gpt.js$script,redirect=googletagservices-gpt,important
  1. Go to - https://www.freundin.de/
  2. Click on any article
  3. Click on back button

Website shows an error.

Screenshot

image

If I'm not wrong, it could be fixed by adding something like:

removeEventListener: noopThis

somewhere here:

Scriptlets/src/redirects/googletagservices-gpt.js

Lines 65 to 68 in 6844de2

const pubAdsService = {
addEventListener: noopThis,
clear: noopFunc,
clearCategoryExclusions: noopThis,

adguard pushed a commit that referenced this issue Mar 15, 2022
@stanislav-atr
improve googletagservices-gpt redirect #193 AG-12767
e724ea1 
Merge in ADGUARD-FILTERS/scriptlets from fix/AG-12767 to release/v1.6

Squashed commit of the following:

commit 4692e34
Merge: 033c3e2 5d11329
Author: Stanislav A <[email protected]>
Date:   Tue Mar 15 15:41:37 2022 +0300

    Merge branch 'release/v1.6' into fix/AG-12767

commit 033c3e2
Author: Stanislav A <[email protected]>
Date:   Tue Mar 15 13:48:12 2022 +0300

    improve googletagservices-gpt redirect
adguard pushed a commit that referenced this issue Mar 24, 2022
@slavaleleka
release v1.6. AG-11978
0921ef0 
* commit 'c06a8e539488e1ebfcf72c85a39a0ef5b9c028bb': (32 commits)
  AG-13382 update docs, validate noopjson
  push updated dist to github while release build. AG-13356
  remove tagcommander redirect AG-11959
  add readme info about testing ad debugging AG-12716
  add artifacts to scriptlets builds AG-12487
  improve set-constant scriptlet #65 AG-149
  improve prevent-xhr scriptlet #199 AG-13007
  improve googletagservices-gpt redirect #193 AG-12767
  add wcslog redirect #94 AG-3906
  improve ati-smarttag redirect #200 AG-13141
  improve json-prune scriptlet #171 AG-11879
  fix yandex metrika on avito #198 AG-12973
  improve metrika-yandex-tag redirect #189 AG-12550
  add prebid-ads redirect #190 AG-12558
  remove no-floc scriptlet AG-12869
  add noopjson redirect. AG-12796 #195
  Revert "revert tests and fix converter again"
  revert tests and fix converter again
  add conversion test for wildcard tld AG-12636
  add prevent-element-src-loading scriptlet #180 AG-12328
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanislav-atr stanislav-atr

Labels
Release: v1.6.2 Resolution: Fixed Status: Closed Version: Scriptlets v1.6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AdamWr @adguard-bot @slavaleleka @stanislav-atr