-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a redirectable script that sets canRunAds true #190
Comments
so this redirect should simply set constant?
|
Yes. Here's an actual bait path: |
there are a lot of just few of none-canrunads ones:
|
Whoa, that is what I certainly missed. It needs evaluation then. From recent Base entries:
Doesn't work
Looks worse than 50:50... |
A few more working cases:
I think the resource is still overall worth, we just need to avoid
Probably setting isAdBlockActive to false too will improve its usefulness. |
Okay, there're two possible approaches:
Which one do you think is better? CC @AdguardTeam/filters-maintainers |
I emphasize that the actual use will be generic filter. There's not much sense to use this only for specific domain as we can use and has been using scriptlet for that. |
I would prefer one redirect ( |
Personally I prefer one constant per stub, otherwise this causes a user to stand out as using a content blocker . i.e. a site could load a script which set |
I actually considered about that but that's no worse than not using stub (no fix) - detected by blocking prebid-ads. Also such detection can be done even with one-constant stub (a website can use a constant inversely - check whether |
Ok I see, the same script file name is used as bait for either sentinel variables, and it wouldn't be possible to create a generic filter that set both variables with one single redirection. |
commit 34a290b Author: Yuki2718 <[email protected]> Date: Mon Feb 7 19:14:02 2022 +0900 update last commit commit f34ffbc Author: Yuki2718 <[email protected]> Date: Mon Feb 7 19:05:17 2022 +0900 Improve and rename canrunads.js Related issue: - AdguardTeam/Scriptlets#190 Related commit: - e8bfc9a
@gorhill I see you've already created a single redirect for few variables |
I made commits after the comment: gorhill/uBlock@ef25f30 |
Merge in ADGUARD-FILTERS/scriptlets from fix/AG-12558 to release/v1.6 Squashed commit of the following: commit b89b88b Merge: 68813a6 7f8bebf Author: Stanislav A <[email protected]> Date: Fri Feb 18 16:36:56 2022 +0300 Merge branch 'release/v1.6' into fix/AG-12558 commit 68813a6 Author: Stanislav A <[email protected]> Date: Fri Feb 18 13:43:28 2022 +0300 update compatibility-table commit 13cc688 Author: Stanislav A <[email protected]> Date: Fri Feb 18 13:15:15 2022 +0300 description fix commit 9e7e637 Author: Stanislav A <[email protected]> Date: Fri Feb 18 12:59:57 2022 +0300 rename redirect commit 6181870 Author: Stanislav A <[email protected]> Date: Thu Feb 17 17:13:39 2022 +0300 add constant-detection-stubs redirect
* commit 'c06a8e539488e1ebfcf72c85a39a0ef5b9c028bb': (32 commits) AG-13382 update docs, validate noopjson push updated dist to github while release build. AG-13356 remove tagcommander redirect AG-11959 add readme info about testing ad debugging AG-12716 add artifacts to scriptlets builds AG-12487 improve set-constant scriptlet #65 AG-149 improve prevent-xhr scriptlet #199 AG-13007 improve googletagservices-gpt redirect #193 AG-12767 add wcslog redirect #94 AG-3906 improve ati-smarttag redirect #200 AG-13141 improve json-prune scriptlet #171 AG-11879 fix yandex metrika on avito #198 AG-12973 improve metrika-yandex-tag redirect #189 AG-12550 add prebid-ads redirect #190 AG-12558 remove no-floc scriptlet AG-12869 add noopjson redirect. AG-12796 #195 Revert "revert tests and fix converter again" revert tests and fix converter again add conversion test for wildcard tld AG-12636 add prevent-element-src-loading scriptlet #180 AG-12328 ...
Related discussion: uBlockOrigin/uAssets@036e131
If this is added, we can add following very wide rules safely:
These should cover not only
bigbtc.win
but many more: https://publicwww.com/?q=%22%2Fprebid-ads.js%22+depth%3Aall See how many/prebid-ads.js
or/ads-prebid.js
rules are in Base filters.The text was updated successfully, but these errors were encountered: