Hide suggestions box completely

[fsobanski]

Is there a way to hide the suggestions box completely if no suggestions have been found? When I use noItemsFoundBuilder: (context) => Container(), I still get the empty box.

[AbdulRahmanAlHamali]

Hello @fsobanski, thank you for reporting the issue!

@sjmcdowall @KaYBlitZ we can maybe provide a parameter hideOnEmpty? What do you guys think?

[fsobanski]

Hi, it would be great if such a parameter would also hide the loading box because it seems weird if the loading box is shown and then just disappears. Thank you for your work on this plugin.

…

On Thu, Jan 24, 2019, 11:28 AbdulRahmanAlHamali ***@***.*** wrote: Hello @fsobanski <https://github.com/fsobanski>, thank you for reporting the issue! @sjmcdowall <https://github.com/sjmcdowall> @KaYBlitZ <https://github.com/KaYBlitZ> we can maybe provide a parameter hideOnEmpty? What do you guys think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Acgvftrth7TxS2On7WRHkYg4WAwF7wwxks5vGYqxgaJpZM4aPdVz> .

[sjmcdowall]

What exactly do you mean by the "loading box" -- can you attach a screen shot?

…

On Jan 24, 2019, at 5:55 AM, Fabian Sobanski ***@***.***> wrote: Hi, it would be great if such a paramezer would also hide the loading box because it seems weird if the loading box is shown and then just disappears. Thank you for your work on this plugin. On Thu, Jan 24, 2019, 11:28 AbdulRahmanAlHamali ***@***.*** wrote: > Hello @fsobanski <https://github.com/fsobanski>, thank you for reporting > the issue! > > @sjmcdowall <https://github.com/sjmcdowall> @KaYBlitZ > <https://github.com/KaYBlitZ> we can maybe provide a parameter hideOnEmpty? > What do you guys think? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#29 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/Acgvftrth7TxS2On7WRHkYg4WAwF7wwxks5vGYqxgaJpZM4aPdVz> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB8M7cpW6fWRS9wfN0PDwfmDnacq8eY9ks5vGZEcgaJpZM4aPdVz>.

[KaYBlitZ]

I believe he means the circle progress indicator that is shown in the suggestions list. It is used when fetching the suggestions take a while.

[fsobanski]

Exactly. The widget that can be controlled via loadingBuilder.

[AbdulRahmanAlHamali]

OK so we can add three parameters: hideOnLoading, hideOnEmpty and hideOnError. We look at each of these parameters in their respective "if" branch in the build function, and we return Container() if the corresponding parameter is set to true.

@fsobanski interested in submitting a pull request? It should be fairly straight forward :)

[sjmcdowall]

@AbdulRahmanAlHamali -- Ok, those use case requirements seem clear enough now. If @fsobanski isn't/can't do it -- I can attack it this weekend.

[sjmcdowall]

So -- I am gathering @fsobanski isn't interested in doing a PR? :) I am busy tonight but unless I hear otherwise I'll give this a shot tomorrow

[AbdulRahmanAlHamali]

@sjmcdowall Go for it! 💪

[KaYBlitZ]

So I took a look at this and I believe everything is working as intended. @fsobanski You used an empty Container() to try to create an empty widget, but looking at the doc: https://docs.flutter.io/flutter/widgets/Container-class.html , it says "Containers with no children try to be as big as possible" which is why we get the empty box displayed since the Container is expanding and taking up space. If you use Container(height: 0) everything works as you intended. There will be no loading box or no items found box.

What do you guys think? I don't think we need to introduce any new code.

[fsobanski]

Sorry, my mistake. Thank you for taking the time. I didn't think enough about the problem.

[AbdulRahmanAlHamali]

Oh I see, well noted @KaYBlitZ! but I think it would be easier and more convenient for the users of the package to just set a parameter to true or false, instead of having to override the builders. What do you think?

[KaYBlitZ]

It would definitely be easier. I can see this being an issue again in the future. I will work on the PR.

[KaYBlitZ]

Added and published! We are officially version 1.0.1!

[sjmcdowall]

Nice!! WOOHOO!

[AbdulRahmanAlHamali]

👏 👏 👏 👏 👏 👏