-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #23 #30
Fix for #23 #30
Conversation
I tested your changes and it fixed the entire screen crash, but the suggestions list box was red (errored). I added in some more missing generic types in a PR request in your repository. Those fixed all errors for me. If you can test and merge those fixes, I think we are good.... |
Added missing generic types
Looks good. Think we are ready to merge if everyone else is fine with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I changed it to merge into develop instead though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KaYBlitZ, @sjmcdowall Btw I think we should release a version 1 by now. Shouldn't we? 😃 |
It will close automatically once we merge into master |
BTW -- I added @KaYBlitZ to the uploaders (or did an add) -- you just need to accept Kenneth. :)
… On Jan 25, 2019, at 6:19 AM, AbdulRahmanAlHamali ***@***.***> wrote:
@KaYBlitZ <https://github.com/KaYBlitZ>, @sjmcdowall <https://github.com/sjmcdowall>
Alright I merged this along with a few fixes to README, I think we can add to them the hideOnLoading, hideOnError and hideOnEmpty properties, and release 0.7.0.
Btw I think we should release a version 1 by now. Shouldn't we? 😃
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB8M7WUentg-OB3SK0ONwLcO_5l2H0iKks5vGuhVgaJpZM4aP6F0>.
|
Thanks a bunch. I just accepted. |
The fix for #23, the state of the widget was created untyped.