Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #23 #30

Merged
merged 3 commits into from
Jan 25, 2019
Merged

Fix for #23 #30

merged 3 commits into from
Jan 25, 2019

Conversation

kika
Copy link
Contributor

@kika kika commented Jan 24, 2019

The fix for #23, the state of the widget was created untyped.

@kika kika mentioned this pull request Jan 24, 2019
@KaYBlitZ
Copy link
Contributor

I tested your changes and it fixed the entire screen crash, but the suggestions list box was red (errored). I added in some more missing generic types in a PR request in your repository. Those fixed all errors for me. If you can test and merge those fixes, I think we are good....

Added missing generic types
@KaYBlitZ KaYBlitZ requested a review from sjmcdowall January 24, 2019 22:06
@KaYBlitZ
Copy link
Contributor

Looks good. Think we are ready to merge if everyone else is fine with it.

@AbdulRahmanAlHamali AbdulRahmanAlHamali changed the base branch from master to develop January 25, 2019 00:18
Copy link
Owner

@AbdulRahmanAlHamali AbdulRahmanAlHamali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I changed it to merge into develop instead though

Copy link
Collaborator

@sjmcdowall sjmcdowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AbdulRahmanAlHamali AbdulRahmanAlHamali merged commit 506aac6 into AbdulRahmanAlHamali:develop Jan 25, 2019
@AbdulRahmanAlHamali
Copy link
Owner

@KaYBlitZ, @sjmcdowall
Alright I merged this along with a few fixes to README, I think we can add to them the hideOnLoading, hideOnError and hideOnEmpty properties, and release 0.7.0.

Btw I think we should release a version 1 by now. Shouldn't we? 😃

@sjmcdowall
Copy link
Collaborator

sjmcdowall commented Jan 25, 2019

As for V 1.0.0 -- Let's get Issue #29 done .. is the Type issue #23 not resolved? I see it's still open?

@AbdulRahmanAlHamali
Copy link
Owner

It will close automatically once we merge into master

@sjmcdowall
Copy link
Collaborator

sjmcdowall commented Jan 25, 2019 via email

@KaYBlitZ
Copy link
Contributor

Thanks a bunch. I just accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants