Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added properties to hide suggestions box #35

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Added properties to hide suggestions box #35

merged 3 commits into from
Feb 7, 2019

Conversation

KaYBlitZ
Copy link
Contributor

@KaYBlitZ KaYBlitZ commented Feb 5, 2019

This adds the properties for hiding the suggestions box in #29

sjmcdowall
sjmcdowall requested changes Feb 5, 2019
View reviewed changes
Copy link
Collaborator

@sjmcdowall sjmcdowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM -- but let's pop this to (finally) 1.0.1 (I hate 1.0.0) LOL .. but I think we're ready for 1.0!

@AbdulRahmanAlHamali
Copy link
Owner

Yup I am with making it 1.0.0 (or .1 😆 ) instead of 0.7.0, but please let's merge into develop not into master

@KaYBlitZ KaYBlitZ changed the base branch from master to develop February 7, 2019 01:57
@KaYBlitZ KaYBlitZ merged commit 1760c46 into AbdulRahmanAlHamali:develop Feb 7, 2019
@sterlp sterlp mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjmcdowall sjmcdowall sjmcdowall requested changes

@AbdulRahmanAlHamali AbdulRahmanAlHamali Awaiting requested review from AbdulRahmanAlHamali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaYBlitZ @AbdulRahmanAlHamali @sjmcdowall